Skip to content

Reviewers cannot edit files even when workflow.reviewer.file-edit in workflow.cfg is set to true #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AdamF42
Copy link
Contributor

@AdamF42 AdamF42 commented May 2, 2025

References

Add references/links to any related issues or PRs. These may include:

Description

Fix the bitstream upload failure during the workflow editing process when a user is impersonating another user.

Instructions for Reviewers

The issue was caused by the missing X-On-Behalf-Of header required to handle impersonation during the file upload process.

List of changes in this PR:

  • Set the X-On-Behalf-Of header with the impersonatingID in the FileUploader class.
  • Added a new field, impersonatingID, to the UploaderOptions
  • Updated UploaderOptions to include the impersonatingID parameter, ensuring it propagates correctly during the upload process.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

AdamF42 added 4 commits May 2, 2025 10:29
(cherry picked from commit 2c79be1456c753665e27b58563e56accc87b0383)
…Options.

(cherry picked from commit c70fe184208805be8657d4373f50f193e2c6e85f)
…ileUploader.

(cherry picked from commit 727bcdc2cb23ae7fcff1d9ddfa794f872f1d1b8c)
@tdonohue tdonohue added bug authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge labels May 2, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 9.0 Release May 2, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdamF42 : I tried testing this today and it does not solve the bug described in the linked ticket DSpace/DSpace#8957
I followed the steps in that ticket & I'm still seeing an error:

  1. Login as administrator
  2. Impersonate a different eperson from "Access control" administrative menu
  3. Start a submission with this impersonated eperson
  4. Upload a file to in progress submission (this works fine)
  5. Try to download the file just added (this is where the ERROR occurs)

That said, I'm confused because this PR seems to be related to workflow reviewers? The title of this PR seems incorrect if it's supposed to fix issue 8957. Did you maybe link this up to the wrong issue ticket?

Basically, I don't understand how to test this PR. There's no clear instructions on what this is fixing and how to test that the bug is fixed.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 9.0 Release May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups bug component: submission
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

When impersonating a submitter it is not possible to download attachments provided to in progress submission
2 participants