-
Notifications
You must be signed in to change notification settings - Fork 497
Update supported Node.js and NPM versions #4816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tdonohue Ah OK great. I can wait until that is merged and then update depending on what needs to be adjusted. We should be targeting v20, v22, and v24 since those are all currently supported LTS releases. |
|
@alanorth : While I understand the desire to target all three Node.js supported versions, we do have to keep in mind that we have a limited number of "free" build hours available in GitHub. So, doing 3 builds per dspace-angular PR might risk us going over that limit. That's why we've tended to choose two Node.js versions to run the build on.... I'd love to do three, but I'm not sure it's possible unless we start paying for GitHub builds. |
Sure, got it. Then we should target v22 and v24. :) |
|
v20 will be EOL in only about six months so it isn't much of a loss. |
5a97a4d to
954f170
Compare
|
Hi @alanorth, |
Supported on current LTS versions of Node.js. See: https://nodejs.org/en/about/previous-releases
Support current active LTS versions. See: https://nodejs.org/en/about/previous-releases
Since we have limited GitHub Actions credits we should only run on the latest two LTS versions (currently v22 and v24). See: https://nodejs.org/en/about/previous-releases
954f170 to
e0be2ea
Compare
Description
Update supported Node.js and NPM versions. As of this writing, the status of Node.js versions is currently:
We should officially only be supporting currently supported Node.js releases that are under maintenance by upstream. The project may or may not build/run with other versions.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
package.jsonto declare supported Node.js and NPM engine versionsREADME.mdto declare supported Node.js and NPM versionsInclude guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.