[Port dspace-9_x] Escape html tags in innerHTML #4737 #4883
Conversation
…rough an innerHTML attribute or not to properly escape them
…rt-4737-to-dspace-9_x
alexandrevryghem
added
bug
high priority
component: Item
alexandrevryghem
moved this to 🙋 Needs Reviewers Assigned
in DSpace Maintenance (9.x, 8.x, 7.6.x)
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@bram-maegerman : Thanks for this backport as well. I gave this a review today, but unfortunately I'm finding a lot of differences between this and the original #4737. The dspace-9_x and main branches are nearly identical at this time, so I'd expect fewer differences. Please take a look at the inline notes below.
I'd be glad to rereview / retest once this is updated.
...object-list/my-dspace-result-list-element/item-list-preview/item-list-preview.component.html
Outdated
Show resolved
Hide resolved
...h-result-grid-element/item-search-result/item/item-search-result-grid-element.component.html
Outdated
Show resolved
Hide resolved
...object-list/my-dspace-result-list-element/item-list-preview/item-list-preview.component.html
Outdated
Show resolved
Hide resolved
...object-list/my-dspace-result-list-element/item-list-preview/item-list-preview.component.html
Outdated
Show resolved
Hide resolved
...st-element/item-search-result/item-types/item/item-search-result-list-element.component.html
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace Maintenance (9.x, 8.x, 7.6.x)
|
Thanks for the review on this backport as well. |
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @bram-maegerman ! Gave this another look/test today and it's looking good and working well. The backport is accurate.
github-project-automation
bot
moved this from 👀 Under Review
to 👍 Reviewer Approved
in DSpace Maintenance (9.x, 8.x, 7.6.x)
github-project-automation
bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (9.x, 8.x, 7.6.x)
3 participants
Port of #4737 by @bram-maegerman to
dspace-9_x