refactor(evm): remove dead L0 cache code#411
Open
ys8888john wants to merge 2 commits intoDTVMStack:mainfrom
Open
refactor(evm): remove dead L0 cache code#411ys8888john wants to merge 2 commits intoDTVMStack:mainfrom
ys8888john wants to merge 2 commits intoDTVMStack:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the previously-disabled “L0” pointer-based module inline cache state from the DTVM EVMC VM implementation, simplifying the module caching logic while keeping the L1 address-based cache with code-content validation.
Changes:
- Removed L0 cache member fields from
DTVM(LastCodePtr,LastCodeSize,L0Mod). - Deleted the remaining L0 eviction/update bookkeeping in
findModuleCached().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
319
to
322
| VM->AddrCache[AddrKey] = Mod; | ||
| } | ||
|
|
||
| // Update L0 cache members. Even though L0 lookup is disabled, we maintain | ||
| // these state variables for two reasons: | ||
| // 1. Eviction tracking: If a stale L1 entry is replaced, we need to | ||
| // invalidate | ||
| // L0Mod if it pointed to the old module (done in the eviction path above). | ||
| // 2. Future extensibility: It keeps the door open for re-enabling L0 later | ||
| // with a safer validation scheme (e.g., pointer + size + hash). | ||
| VM->LastCodePtr = Code; | ||
| VM->LastCodeSize = CodeSize; | ||
| VM->L0Mod = Mod; | ||
| return Mod; |
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 1 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
Contributor
|
conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note