Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

added and implemented query restrictions #14

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions redash/query_runner/snowflake.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
TYPE_BOOLEAN,
)
from redash.utils import json_dumps, json_loads
import re

TYPES_MAP = {
0: TYPE_INTEGER,
Expand All @@ -30,6 +31,31 @@
}


def _query_restrictions(query):
query_without_comments = ''
for line in query.split('\n'):
line = line.strip()
if line.find('--') != -1:
line = line[:line.find('--')]
query_without_comments += ' ' + line # creates one line query
query = query_without_comments
query = query.lower()
# replace multiple spaces with one space
query = re.sub(' +', ' ', query)
# get rid of prefix like bigbrain. or final.
query = re.sub('bigbrain.', '', re.sub('final.', '', re.sub('raw.', '', query)))
occurrences = re.findall(" from events ", query) + re.findall(" join events ", query)
# print("num of occurrences : ", len(occurrences))
if len(occurrences) > 1:
return False, f'Querying events table multiple times is forbidden.The query contains {len(occurrences)} occurrences of the table events.'

if occurrences:
if query.find("create_at") + query.find("ingestion_time") == -2:
return False, 'Querying events table should always be with time constraint (by created_at for ' \
'FINAL.events & ingestion_time for RAW.events) '
return True, ''


class Snowflake(BaseQueryRunner):
noop_query = "SELECT 1"

Expand Down Expand Up @@ -128,6 +154,11 @@ def run_query(self, query, user, query_id=None):
connection = self._get_connection()
cursor = connection.cursor()

passed, message = _query_restrictions(query)

if not passed:
return None, message

try:
cursor.execute("USE WAREHOUSE {}".format(self.configuration["warehouse"]))
cursor.execute("USE {}".format(self.configuration["database"]))
Expand Down