Migrate Application Information View from XML to Compose#651
Merged
Migrate Application Information View from XML to Compose#651
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Application Information view from an XML-based approach to a new Compose implementation while removing the legacy XML fragments and related navigation actions. Key changes include:
- Deleting the old XML layout files and fragments for policy and information screens.
- Introducing a new Compose-based AppInformationScreen and adjusting navigation/routes and SettingsScreen to handle the new composable.
- Updating navigation and main navigator to integrate the new information and rules screens.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| presentation/src/main/res/values/strings.xml | Removed redundant string resources no longer needed for the new Compose view. |
| presentation/src/main/res/navigation/nav_graph.xml | Removed navigation actions and fragment entries for legacy screens. |
| presentation/src/main/res/layout/fragment_policy.xml | Deleted legacy XML layout. |
| presentation/src/main/res/layout/fragment_information.xml | Deleted legacy XML layout. |
| presentation/src/main/res/drawable/ic_chevron_r.xml | Added a new drawable for the information screen. |
| presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsScreen.kt | Updated settings screen to include onInformationClick callbacks. |
| presentation/src/main/java/daily/dayo/presentation/screen/settings/SettingsNavigation.kt | Added new navigation composables and routes for the information screen and rules. |
| presentation/src/main/java/daily/dayo/presentation/screen/settings/AppInformationScreen.kt | Created a new Compose-based screen to display application information. |
| presentation/src/main/java/daily/dayo/presentation/screen/main/MainScreen.kt | Updated main screen to route to the new information and rules screens. |
| presentation/src/main/java/daily/dayo/presentation/screen/main/MainNavigator.kt | Enhanced navigator with methods for navigating to the information and rules screens. |
| presentation/src/main/java/daily/dayo/presentation/fragment/setting/information/InformationFragment.kt | Removed the legacy XML fragment file. |
| presentation/src/main/java/daily/dayo/presentation/fragment/setting/SettingFragment.kt | Removed the navigation call to the legacy information fragment. |
| presentation/src/main/java/daily/dayo/presentation/fragment/policy/PolicyFragment.kt | Removed the legacy policy fragment file. |
…dException) in getAppVersion to prevent potential crashes if package information retrieval fails Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yuni-ju
requested changes
May 28, 2025
Member
yuni-ju
left a comment
yuni-ju
left a comment
There was a problem hiding this comment.
스크롤 시 보라색으로 표시되는데 의도치 않은 동작일 것 같아요!
Member
Author
재현 불가로 처리 부탁드립니다. |
Member
|
에뮬레이터랑 기기 모두 직접 테마 스타일에 혹여나 보라색으로 뜰 가능성을 대비해서 |
yuni-ju
approved these changes
Jun 2, 2025
DongJun-H
pushed a commit
that referenced
this pull request
Feb 3, 2026
DongJun-H
added a commit
that referenced
this pull request
Feb 3, 2026
Migrate Application Information View from XML to Compose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업사항
참고