Fix inconsistent behavior between soft back key and back icon button#659
Merged
Fix inconsistent behavior between soft back key and back icon button#659
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the device back button and the action bar back icon perform the same navigation in the search screens.
- Adds
BackHandlertoSearchRoutefor consistent back behavior. - Adds
BackHandlertoSearchResultRoutefor consistent back behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SearchScreen.kt | Imported BackHandler and wired onBackClick() to it |
| SearchResultScreen.kt | Imported BackHandler and wired onBackClick() to it |
Comments suppressed due to low confidence (2)
presentation/src/main/java/daily/dayo/presentation/screen/search/SearchScreen.kt:72
- Consider adding a UI or integration test to verify that both the hardware back button and the action bar back icon invoke
onBackClick()in this screen.
BackHandler {
presentation/src/main/java/daily/dayo/presentation/screen/search/SearchResultScreen.kt:109
- Consider adding a UI or integration test to verify that both the hardware back button and the action bar back icon invoke
onBackClick()in this screen.
BackHandler {
yuni-ju
requested changes
May 28, 2025
Member
yuni-ju
left a comment
There was a problem hiding this comment.
May-28-2025.22-22-05.mp4
-
최근검색어에서 키워드를 클릭했을때는 검색화면에서 바로 뒤로가기가 되는데, 직접 검색어를 입력한 후 뒤로가기를 누르면 두번 눌러야 뒤로가지는 현상이 발생합니다.
-
이건 이번 이슈랑은 관계 없지만... 최근 검색어에 test말고 아래 한글로된 검색어가 가운데 정렬이 안되어있는 것 --> 제가 습관적으로 엔터 버튼을 눌렀더니 검색어에 줄바꿈 기호가 포함되는 것 같더라구요! 요것도 추후 제거 되면 좋을 것 같아요
Member
Author
|
yuni-ju
approved these changes
Jun 2, 2025
DongJun-H
added a commit
that referenced
this pull request
Feb 3, 2026
Fix inconsistent behavior between soft back key and back icon button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업목표
작업사항
참고