fix issue resolving overload with polymorphic arguments when passed …

[DarathDev]

…a pointer to a generic from another function

Attempts to fix #1495

The problem seems to be that during resolve_generic_function_symbol the parameter resolves to the type without the pointer, as symbol_to_expr doesn't retain that information. I am not certain if that is intended. The changes in this pull request change that, but it breaks several other tests, and causes the server to crash.

Is there another mechanism by which this information should normally be retained, or is it an oversight of symbol_to_expr?

[BradLewis]

I'm not 100% sure, but if it's breaking other tests like that it's probably intended to work like this. My guess is it's something like it's not correctly recursing down to realise it should be a ^Bar and not just a Bar.

This should be a similar test case that demonstrates the same problem which should make debugging easier.

package test

Bar :: struct{}

bar_ptr :: proc(value: $T) -> ^T {}

bar_pass :: proc(value: $T) -> T {}

main :: proc() {
	b := bar_ptr(Bar{})
	c := bar_pass(b)
}

[BradLewis]

Thanks! Works well for me.