Corax

code/__DEFINES/~darkpack/combat.dm

@@ -17,3 +17,7 @@
 #define LETHAL "lethal"
 // exists in code/__DEFINES/~darkpack/aggravated_damage.dm
 //#define AGGRAVATED
+
+// To convert a measure of yards into tiles/range
+#define YARDS / 5
+#define YARDS_TO_TILES * 5

code/__DEFINES/~darkpack/fera/fera.dm

@@ -9,10 +9,13 @@
 #define MAX_GNOSIS 10
 #define PRIMAL_URGE_PLACEHOLDER 3
 
-#define BREED_HOMID "Homid"
+#define BREED_GAROU_HOMID "Garou Homid"
 #define BREED_LUPUS "Lupus"
 #define BREED_CRINOS "Crinos"
 
+#define BREED_CORAX_HOMID "Corax Homid"
+#define BREED_CORVID "Corvid"
+
 #define FEATURE_FUR_COLOR "fera_fur"
 
 // fera will likely have a seperate list of colors but uses the same feature or var as other fera
@@ -22,7 +25,16 @@ GLOBAL_LIST_INIT(garou_fur_colors, list(
 	"red" = "red",
 	"white" = "white",
 	"ginger" = "ginger",
-	"brown" = "brown"
+	"brown" = "brown",
+))
+
+GLOBAL_LIST_INIT(corax_fur_colors, list(
+	"black" = "black",
+	"brown" = "brown",
+	"white" = "white",
+	"green" = "green",
+	"red" = "red",
+	"gray" = "gray",
 ))
 
 #define STATUS_EFFECT_DELIRIUM /datum/status_effect/delirium

code/__DEFINES/~darkpack/fera/werewolf_tribe.dm

@@ -16,10 +16,8 @@
 #define TRIBE_STARGAZERS "Stargazers"
 #define TRIBE_BLACK_SPIRAL_DANCERS "Black Spiral Dancers"
 
-#define TRIBE_CORAX "Corax" // DARKPACK TODO - CORAX
-
-#define TRIBE_LIST_ALL list(TRIBE_RONIN, TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_GLASS_WALKERS, TRIBE_BONE_GNAWERS, TRIBE_SHADOW_LORDS, TRIBE_BLACK_SPIRAL_DANCERS, TRIBE_CORAX)
-#define TRIBE_LIST_GAIA list(TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_GLASS_WALKERS, TRIBE_BONE_GNAWERS, TRIBE_SHADOW_LORDS, TRIBE_CORAX)
-#define TRIBE_LIST_WYLD list(TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_SHADOW_LORDS, TRIBE_CORAX)
+#define TRIBE_LIST_ALL list(TRIBE_RONIN, TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_GLASS_WALKERS, TRIBE_BONE_GNAWERS, TRIBE_SHADOW_LORDS, TRIBE_BLACK_SPIRAL_DANCERS)
+#define TRIBE_LIST_GAIA list(TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_GLASS_WALKERS, TRIBE_BONE_GNAWERS, TRIBE_SHADOW_LORDS)
+#define TRIBE_LIST_WYLD list(TRIBE_GALESTALKERS, TRIBE_CHILDREN_OF_GAIA, TRIBE_UKTENA, TRIBE_FIANNA, TRIBE_GET_OF_FENRIS, TRIBE_BLACK_FURIES, TRIBE_SILVER_FANGS, TRIBE_SILENT_STRIDERS, TRIBE_RED_TALONS, TRIBE_STARGAZERS, TRIBE_SHADOW_LORDS)
 #define TRIBE_LIST_WEAVER list(TRIBE_GLASS_WALKERS, TRIBE_BONE_GNAWERS)
 #define TRIBE_LIST_WYRM list(TRIBE_BLACK_SPIRAL_DANCERS)

code/__DEFINES/~darkpack/splats.dm

@@ -8,7 +8,7 @@
 /// Parent type for shifters. Not player facing. Shouldnt be needed but put here for clarity.
 //#define SPLAT_FERA "splat_fera"
 #define SPLAT_GAROU "splat_garou"
-#define SPLAT_CORAX "splat_corax" // DARKPACK TODO - CORAX
+#define SPLAT_CORAX "splat_corax"
 #define SPLAT_SHIFTERS list(SPLAT_GAROU, SPLAT_CORAX)
 
 #define SPLAT_PRIO_HALFSPLAT 100

code/__DEFINES/~darkpack/traits/declarations.dm

@@ -128,12 +128,6 @@ Remember to update _globalvars/traits.dm if you're adding/removing/renaming trai
 #define TRAIT_FERA_FORMS "fera_forms"
 // If the splat uses the WTA renown system described in W20 p. 245
 #define TRAIT_FERA_RENOWN "wta_fera_renown"
-/// If the species has garou breeds to select.
-#define TRAIT_WTA_GAROU_BREED "wta_garou_breeds"
-// if the species has garou tribes to select.
-#define TRAIT_WTA_GAROU_TRIBE "wta_garou_tribes"
-// If the species has garou auspices to select.
-#define TRAIT_WTA_GAROU_AUSPICE "wta_garou_auspice"
 // This mob has fur!
 #define TRAIT_FERA_FUR "fera_fur"
 /// If the fera is wyrm tainted.
@@ -144,11 +138,17 @@ Remember to update _globalvars/traits.dm if you're adding/removing/renaming trai
 #define TRAIT_NO_LYING_ANGLE "no_lying_angle"
 // Expensive but allows us to ensure there resting gets updated.
 #define TRAIT_TRANSFORM_UPDATES_ICON "transform_updates_icon"
+// Fera both grants a flight ability, and has the sprites to support such a thing. (Presently only designed to supprot feral form.)
+#define TRAIT_FERA_FLIGHT "fera_flight"
+#define TRAIT_SILVER_WEAKNESS "silver_weakness"
+#define TRAIT_GOLD_WEAKNESS "gold_weakness"
+// Delirium is effectivly two levels weaker
+#define TRAIT_WEAK_DELIRIUM "weak_delirium"
+// Massivly boosts the range of your howl emote.
+#define TRAIT_LOUD_WARCRY "loud_warcry"
 /// Prevents the mob from picking up items larger then small
 #define TRAIT_SMALL_HANDS "small_hands"
 // Traits granted via gifts
-// Massivly boosts the range of your howl emote.
-#define TRAIT_LOUD_HOWLER "loud_howler"
 #define TRAIT_RAZOR_CLAWS "razor_claws"
 
 /// Sixth sense restricted to view range

code/_globalvars/traits/_traits.dm

@@ -693,12 +693,14 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_ENHANCED_MELEE_DODGE" = TRAIT_ENHANCED_MELEE_DODGE, // DARKPACK EDIT ADD
 		"TRAIT_FAIR_GLABRO" = TRAIT_FAIR_GLABRO, // DARKPACK EDIT ADD - MERITS_FLAWS
 		"TRAIT_FEEDING_RESTRICTION" = TRAIT_FEEDING_RESTRICTION, // DARKPACK EDIT ADD
+		"TRAIT_FERA_FLIGHT" = TRAIT_FERA_FLIGHT, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_FERA_FORMS" = TRAIT_FERA_FORMS, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_FERA_FUR" = TRAIT_FERA_FUR, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_FERA_RENOWN" = TRAIT_FERA_RENOWN, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_FORCED_EMOTION" = TRAIT_FORCED_EMOTION, // DARKPACK EDIT ADD - Melpominee
 		"TRAIT_FRENETIC_AURA" = TRAIT_FRENETIC_AURA, // DARKPACK EDIT ADD
 		"TRAIT_GHOST_VISION" = TRAIT_GHOST_VISION, // DARKPACK EDIT ADD - POWERS - (Necromancy)
+		"TRAIT_GOLD_WEAKNESS" = TRAIT_GOLD_WEAKNESS, // DARKPACK EDIT ADD - WEREWOLF - (corax)
 		"TRAIT_GRIP_OF_THE_DAMNED" = TRAIT_GRIP_OF_THE_DAMNED, // DARKPACK EDIT ADD
 		"TRAIT_GULLET" = TRAIT_GULLET, // DARKPACK EDIT ADD
 		"TRAIT_HOMOSEXUAL" = TRAIT_HOMOSEXUAL, // DARKPACK EDIT ADD
@@ -712,7 +714,7 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_LAZY" = TRAIT_LAZY, // DARKPACK EDIT ADD
 		"TRAIT_LIGHT_WEAKNESS" = TRAIT_LIGHT_WEAKNESS, // DARKPACK EDIT ADD - Setite Flaw
 		"TRAIT_LOCAL_SIXTHSENSE" = TRAIT_LOCAL_SIXTHSENSE, // DARKPACK EDIT ADD
-		"TRAIT_LOUD_HOWLER" = TRAIT_LOUD_HOWLER, // DARKPACK EDIT ADD - WEREWOLF
+		"TRAIT_LOUD_WARCRY" = TRAIT_LOUD_WARCRY, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_MASQUERADE_VIOLATING_EYES" = TRAIT_MASQUERADE_VIOLATING_EYES, // DARKPACK EDIT ADD
 		"TRAIT_MASQUERADE_VIOLATING_FACE" = TRAIT_MASQUERADE_VIOLATING_FACE, // DARKPACK EDIT ADD
 		"TRAIT_MERIT_UNTAMABLE" = TRAIT_MERIT_UNTAMABLE, // DARKPACK EDIT ADD - MERITS_FLAWS
@@ -739,13 +741,13 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_SENSITIVE_HUMANITY" = TRAIT_SENSITIVE_HUMANITY, // DARKPACK EDIT ADD
 		"TRAIT_SERPENTIS_SKIN" = TRAIT_SERPENTIS_SKIN, // DARKPACK EDIT ADD - POWERS - (Serpentis)
 		"TRAIT_SILENCED" = TRAIT_SILENCED, // DARKPACK EDIT ADD - POWERS - (Quietus)
+		"TRAIT_SILVER_WEAKNESS" = TRAIT_SILVER_WEAKNESS, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_SMALL_HANDS" = TRAIT_SMALL_HANDS, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_STAKED" = TRAIT_STAKED, // DARKPACK EDIT ADD
 		"TRAIT_STAKE_IMMUNE" = TRAIT_STAKE_IMMUNE, // DARKPACK EDIT ADD
 		"TRAIT_STAKE_RESISTANT" = TRAIT_STAKE_RESISTANT, // DARKPACK EDIT ADD
 		"TRAIT_STILLNESS_OF_DEATH" = TRAIT_STILLNESS_OF_DEATH, // DARKPACK EDIT ADD - Gargoyle Quirk
 		"TRAIT_THE_LARGEST_MAW" = TRAIT_THE_LARGEST_MAW, // DARKPACK EDIT ADD - MERITS/FLAWS
-		"TRAIT_THE_LARGEST_MAW" = TRAIT_THE_LARGEST_MAW, // DARKPACK EDIT ADD - MERITS/FLAWS
 		"TRAIT_THIRD_EYE" = TRAIT_THIRD_EYE, // DARKPACK EDIT ADD - Tremere & Salubri Quirk
 		"TRAIT_TIMEWARPER" = TRAIT_TIMEWARPER, // DARKPACK EDIT ADD
 		"TRAIT_TIME_SENSE" = TRAIT_TIME_SENSE, // DARKPACK EDIT ADD - MERITS_FLAWS
@@ -762,11 +764,9 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_VITAE_ADDICTION" = TRAIT_VITAE_ADDICTION, // DARKPACK EDIT ADD
 		"TRAIT_VTM_CLANS" = TRAIT_VTM_CLANS, // DARKPACK EDIT ADD
 		"TRAIT_VTM_MORALITY" = TRAIT_VTM_MORALITY, // DARKPACK EDIT ADD
+		"TRAIT_WEAK_DELIRIUM" = TRAIT_WEAK_DELIRIUM, // DARKPACK EDIT ADD - WEREWOLF - (corax)
 		"TRAIT_WEAK_TO_DOMINATE" = TRAIT_WEAK_TO_DOMINATE, // DARKPACK EDIT ADD - POWERS - (Dominate)
 		"TRAIT_WEAK_WILLED" = TRAIT_WEAK_WILLED, // DARKPACK EDIT ADD - MERITS_FLAWS
-		"TRAIT_WTA_GAROU_AUSPICE" = TRAIT_WTA_GAROU_AUSPICE, // DARKPACK EDIT ADD - WEREWOLF
-		"TRAIT_WTA_GAROU_BREED" = TRAIT_WTA_GAROU_BREED, // DARKPACK EDIT ADD - WEREWOLF
-		"TRAIT_WTA_GAROU_TRIBE" = TRAIT_WTA_GAROU_TRIBE, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_WYRMTAINTED" = TRAIT_WYRMTAINTED, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_WYRMTAINTED_SPRITE" = TRAIT_WYRMTAINTED_SPRITE, // DARKPACK EDIT ADD - WEREWOLF
 	),

code/_globalvars/traits/admin_tooling.dm

@@ -387,6 +387,7 @@ GLOBAL_LIST_INIT(admin_visible_traits, list(
 		"TRAIT_FERA_RENOWN" = TRAIT_FERA_RENOWN, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_FRENETIC_AURA" = TRAIT_FRENETIC_AURA, // DARKPACK EDIT ADD
 		"TRAIT_GHOST_VISION" = TRAIT_GHOST_VISION, // DARKPACK EDIT ADD - POWERS - (Necromancy)
+		"TRAIT_GOLD_WEAKNESS" = TRAIT_GOLD_WEAKNESS, // DARKPACK EDIT ADD - WEREWOLF - (corax)
 		"TRAIT_GRIP_OF_THE_DAMNED" = TRAIT_GRIP_OF_THE_DAMNED, // DARKPACK EDIT ADD
 		"TRAIT_GULLET" = TRAIT_GULLET, // DARKPACK EDIT ADD
 		"TRAIT_HOMOSEXUAL" = TRAIT_HOMOSEXUAL, // DARKPACK EDIT ADD
@@ -399,9 +400,8 @@ GLOBAL_LIST_INIT(admin_visible_traits, list(
 		"TRAIT_LAZY" = TRAIT_LAZY, // DARKPACK EDIT ADD
 		"TRAIT_LIGHT_WEAKNESS" = TRAIT_LIGHT_WEAKNESS, // DARKPACK EDIT ADD - Setite Flaw
 		"TRAIT_LOCAL_SIXTHSENSE" = TRAIT_LOCAL_SIXTHSENSE, // DARKPACK EDIT ADD
-		"TRAIT_LOUD_HOWLER" = TRAIT_LOUD_HOWLER, // DARKPACK EDIT ADD - WEREWOLF
+		"TRAIT_LOUD_WARCRY" = TRAIT_LOUD_WARCRY, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_MASQUERADE_VIOLATING_EYES" = TRAIT_MASQUERADE_VIOLATING_EYES, // DARKPACK EDIT ADD
-		"TRAIT_MASQUERADE_VIOLATING_FACE" = TRAIT_MASQUERADE_VIOLATING_FACE, // DARKPACK EDIT ADD
 		"TRAIT_MERIT_UNTAMABLE" = TRAIT_MERIT_UNTAMABLE, // DARKPACK EDIT ADD - MERITS_FLAWS
 		"TRAIT_METAMORPH" = TRAIT_METAMORPH, // DARKPACK EDIT ADD - MERITS_FLAWS
 		"TRAIT_NEEDS_BLOOD" = TRAIT_NEEDS_BLOOD, // DARKPACK EDIT ADD - Hunger and Frenzy
@@ -422,6 +422,7 @@ GLOBAL_LIST_INIT(admin_visible_traits, list(
 		"TRAIT_SENSITIVE_HUMANITY" = TRAIT_SENSITIVE_HUMANITY, // DARKPACK EDIT ADD
 		"TRAIT_SERPENTIS_SKIN" = TRAIT_SERPENTIS_SKIN, // DARKPACK EDIT ADD - POWERS - (Serpentis)
 		"TRAIT_SILENCED" = TRAIT_SILENCED, // DARKPACK EDIT ADD - POWERS - (Quietus)
+		"TRAIT_SILVER_WEAKNESS" = TRAIT_SILVER_WEAKNESS, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_SMALL_HANDS" = TRAIT_SMALL_HANDS, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_STAKED" = TRAIT_STAKED, // DARKPACK EDIT ADD
 		"TRAIT_STAKE_IMMUNE" = TRAIT_STAKE_IMMUNE, // DARKPACK EDIT ADD
@@ -439,11 +440,9 @@ GLOBAL_LIST_INIT(admin_visible_traits, list(
 		"TRAIT_VITAE_ADDICTION" = TRAIT_VITAE_ADDICTION, // DARKPACK EDIT ADD
 		"TRAIT_VTM_CLANS" = TRAIT_VTM_CLANS, // DARKPACK EDIT ADD
 		"TRAIT_VTM_MORALITY" = TRAIT_VTM_MORALITY, // DARKPACK EDIT ADD
+		"TRAIT_WEAK_DELIRIUM" = TRAIT_WEAK_DELIRIUM, // DARKPACK EDIT ADD - WEREWOLF - (corax)
 		"TRAIT_WEAK_TO_DOMINATE" = TRAIT_WEAK_TO_DOMINATE, // DARKPACK EDIT ADD - POWERS - (Dominate)
 		"TRAIT_WEAK_WILLED" = TRAIT_WEAK_WILLED, // DARKPACK EDIT ADD - MERITS_FLAWS
-		"TRAIT_WTA_GAROU_AUSPICE" = TRAIT_WTA_GAROU_AUSPICE, // DARKPACK EDIT ADD - WEREWOLF
-		"TRAIT_WTA_GAROU_BREED" = TRAIT_WTA_GAROU_BREED, // DARKPACK EDIT ADD - WEREWOLF
-		"TRAIT_WTA_GAROU_TRIBE" = TRAIT_WTA_GAROU_TRIBE, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_WYRMTAINTED" = TRAIT_WYRMTAINTED, // DARKPACK EDIT ADD - WEREWOLF
 		"TRAIT_WYRMTAINTED_SPRITE" = TRAIT_WYRMTAINTED_SPRITE, // DARKPACK EDIT ADD - WEREWOLF
 	),

code/modules/client/preferences.dm

@@ -347,7 +347,7 @@ GLOBAL_LIST_EMPTY(preferences_datums)
 	var/list/preferences = list()
 
 	for (var/datum/preference/preference as anything in get_preferences_in_priority_order())
-		if (!preference.is_accessible(src))
+		if (!preference.visible_in_page(src)) // DARKPACK EDIT CHANGE - (is_accessible to visible_in_page)
 			continue
 
 		var/value = read_preference(preference.type)
@@ -579,6 +579,9 @@ GLOBAL_LIST_EMPTY(preferences_datums)
 		if (preference.must_have_relevant_trait && preference.relevant_inherent_trait)
 			if (!HAS_TRAIT(character, preference.relevant_inherent_trait))
 				continue
+
+		if (preference.must_be_accessible && !preference.is_accessible(src))
+			continue
 		// DARKPACK EDIT ADD END - TTRPG preferences
 
 		preference.apply_to_human(character, read_preference(preference.type))

code/modules/client/preferences/_preference.dm

@@ -307,7 +307,7 @@ GLOBAL_LIST_INIT(preference_entries_by_key, init_preference_entries_by_key())
 /// This will, for instance, update the character preference view.
 /// Performs sanity checks.
 /datum/preferences/proc/update_preference(datum/preference/preference, preference_value)
-	if (!preference.is_accessible(src))
+	if (!preference.visible_in_page(src)) // DARKPACK EDIT CHANGE - (is_accessible to visible_in_page)
 		return FALSE
 
 	var/new_value = preference.deserialize(preference_value, src)
@@ -377,11 +377,24 @@ GLOBAL_LIST_INIT(preference_entries_by_key, init_preference_entries_by_key())
 	if (!has_relevant_feature(preferences))
 		return FALSE
 
+	/* // DARKPACK EDIT REMOVAL - Moved to a wrapper proc
 	if (!should_show_on_page(preferences.current_window))
 		return FALSE
+	*/
 
 	return TRUE
 
+// DARKPACK EDIT ADD START
+/datum/preference/proc/visible_in_page(datum/preferences/preferences)
+	SHOULD_CALL_PARENT(TRUE)
+	SHOULD_NOT_SLEEP(TRUE)
+
+	if (!should_show_on_page(preferences.current_window))
+		return FALSE
+
+	return is_accessible(preferences)
+// DARKPACK EDIT ADD END
+
 /// Returns whether or not, given the PREFERENCE_TAB_*, this preference should
 /// appear.
 /datum/preference/proc/should_show_on_page(preference_tab)

code/modules/client/preferences_savefile.dm

@@ -187,8 +187,8 @@ SAVEFILE UPDATING/VERSIONING - 'Simplified', or rather, more coder-friendly ~Car
 
 /datum/preferences/proc/update_character_darkpack(current_version, list/save_data)
 	if (current_version < 2)
-		if(read_preference(/datum/preference/choiced/subsplat/garou_breed) == "Metis")
-			write_preference(GLOB.preference_entries[/datum/preference/choiced/subsplat/garou_breed], BREED_CRINOS)
+		if(read_preference(/datum/preference/choiced/subsplat/fera_breed/garou) == "Metis")
+			write_preference(GLOB.preference_entries[/datum/preference/choiced/subsplat/fera_breed/garou], BREED_CRINOS)
 // DARKPACK EDIT ADD END
 
 /// checks through keybindings for outdated unbound keys and updates them

config/darkpack_config.txt

@@ -43,6 +43,7 @@ ROUNDSTART_SPLATS splat_kindred
 ROUNDSTART_SPLATS splat_ghoul
 ROUNDSTART_SPLATS splat_kinfolk
 ROUNDSTART_SPLATS splat_garou
+ROUNDSTART_SPLATS splat_corax
 
 ## If dead people and ghosts can LOOC to people who are alive.
 DISABLE_GHOST_LOOC

modular_darkpack/master_files/code/modules/client/preferences/_preference.dm

@@ -2,3 +2,5 @@
 	/// If set to TRUE, this preference will not be applied unless the character has the preference's relevant inherent trait
 	var/must_have_relevant_trait = FALSE
 
+	/// If set to TRUE, only apply preference to the mob if it acctually shows up on there sheet
+	var/must_be_accessible = FALSE

modular_darkpack/master_files/code/modules/mob/living/carbon/human/_species.dm

@@ -1,4 +1,4 @@
 
-/datum/species
-	/// Used in get_generic_name to replace gender
-	var/visible_gender_override
+/// Used in get_generic_name to replace gender
+/datum/species/proc/visible_gender_override(mob/living/carbon/human/holder)
+	return

modular_darkpack/master_files/code/modules/mob/living/carbon/human/death.dm

@@ -7,3 +7,19 @@
 	GLOB.masquerade_breakers_list -= src
 	GLOB.sabbatites -= src
 
+	last_death_info = new()
+	last_death_info.record_death(src)
+
+
+// Not an override. Usecases will be spread out across modules so it goes here.
+/datum/death_report
+	var/area
+	var/last_words
+	var/last_attacker_name
+	var/suicide
+
+/datum/death_report/proc/record_death(mob/living/carbon/human/dead_guy)
+	area = get_area(dead_guy)
+	last_attacker_name = dead_guy.lastattacker
+	last_words = dead_guy.last_words
+	suicide = HAS_TRAIT(dead_guy, TRAIT_SUICIDED)

modular_darkpack/master_files/code/modules/mob/living/carbon/human/human_defines.dm

@@ -10,3 +10,5 @@
 	// Visible adjectives, used for Guestbooks.
 	var/visible_adjective = ""
 
+	/// A datum that tracks all the information at the time of there death. Used for powers that tell you the sitatuons of there demise.
+	var/datum/death_report/last_death_info

modular_darkpack/modules/guestbook/code/human_helpers.dm

@@ -7,8 +7,9 @@
 			visible_gender = "Woman"
 		else
 			visible_gender = "Person"
-	if(dna?.species.visible_gender_override)
-		visible_gender = dna.species.visible_gender_override
+	var/override = dna?.species.visible_gender_override(src)
+	if(override)
+		visible_gender = override
 
 	return visible_gender
 

modular_darkpack/modules/jobs/code/_job_assignment.dm

@@ -72,15 +72,15 @@
 		return JOB_UNAVAILABLE_KINDRED_CLAN
 
 /datum/controller/subsystem/job/proc/check_garou_prefs(client/player_client, mob/dead/new_player/player, datum/job/possible_job, debug_prefix = "", add_job_to_log = FALSE)
-	var/datum/subsplat/werewolf/auspice/auspice = get_fera_auspice(player_client.prefs.read_preference(/datum/preference/choiced/subsplat/garou_auspice))
+	var/datum/subsplat/werewolf/auspice/auspice = get_fera_auspice(player_client.prefs.read_preference(/datum/preference/choiced/subsplat/fera_auspice/garou))
 	if(possible_job.allowed_auspice && !(auspice.name in possible_job.allowed_auspice))
 		job_debug("[debug_prefix] Error: [get_job_unavailable_error_message(JOB_UNAVAILABLE_FERA_AUSPICE, possible_job.title)], Player: [player][add_job_to_log ? ", Job: [possible_job]" : ""]")
 		return JOB_UNAVAILABLE_FERA_AUSPICE
 	if(possible_job.disallowed_auspice && (auspice.name in possible_job.disallowed_auspice))
 		job_debug("[debug_prefix] Error: [get_job_unavailable_error_message(JOB_UNAVAILABLE_FERA_AUSPICE, possible_job.title)], Player: [player][add_job_to_log ? ", Job: [possible_job]" : ""]")
 		return JOB_UNAVAILABLE_FERA_AUSPICE
 
-	var/datum/subsplat/werewolf/tribe/tribe = get_fera_tribe(player_client.prefs.read_preference(/datum/preference/choiced/subsplat/garou_tribe))
+	var/datum/subsplat/werewolf/tribe/tribe = get_fera_tribe(player_client.prefs.read_preference(/datum/preference/choiced/subsplat/fera_tribe/garou))
 	if(possible_job.allowed_tribes && !(tribe.name in possible_job.allowed_tribes))
 		job_debug("[debug_prefix] Error: [get_job_unavailable_error_message(JOB_UNAVAILABLE_FERA_TRIBE, possible_job.title)], Player: [player][add_job_to_log ? ", Job: [possible_job]" : ""]")
 		return JOB_UNAVAILABLE_FERA_TRIBE

modular_darkpack/modules/splats/code/splat_management.dm

@@ -55,7 +55,7 @@
  */
 /mob/living/proc/is_splat_compatible(splat_type)
 	for (var/datum/splat/splat as anything in splats)
-		if (splat_type in splat.incompatible_splats)
+		if (is_type_in_list(splat_type, splat.incompatible_splats))
 			return FALSE
 		if (splat.type == splat_type)
 			return FALSE

modular_darkpack/modules/unit_tests/apply_all_splats.dm

@@ -49,8 +49,8 @@
 			splat_prio_list["[splat_prio]"] = splat_type
 		else
 			var/datum/splat/checking_type = splat_prio_list["[splat_prio]"]
-			var/datum/splat/real_splat = GLOB.splat_prototypes[checking_type::id]
-			if(splat_type in real_splat.incompatible_splats)
+			var/datum/splat/real_splat = GLOB.splat_prototypes[checking_type]
+			if(is_path_in_list(checking_type, real_splat.incompatible_splats))
 				continue
 			TEST_FAIL("[splat_type] has the same splat priority as [splat_prio_list["[splat_prio]"]] yet is somehow compatible. priority is [splat_prio].")
 

modular_darkpack/modules/weapons/code/projectiles.dm

@@ -198,7 +198,7 @@
 	name = "7.62x51mm silver bullet"
 	armour_penetration = 20
 
-/obj/projectile/bullet/darkpack/vamp762x51mm/silver/on_hit(atom/target, blocked = 0, pierce_hit)
+/obj/projectile/bullet/darkpack/vamp762x51mm/silver/on_hit(atom/target, blocked = FALSE, pierce_hit)
 	. = ..()
 	fera_silver_damage(target, 4)
 
@@ -213,6 +213,6 @@
 	name = ".75 silver ball"
 	armour_penetration = 0
 
-/obj/projectile/bullet/darkpack/vamp75/silver/on_hit(atom/target, blocked = 0, pierce_hit)
+/obj/projectile/bullet/darkpack/vamp75/silver/on_hit(atom/target, blocked = FALSE, pierce_hit)
 	. = ..()
-	fera_silver_damage(target, 5)	//Same as silver longsword; it's a solid silver ball. As the founding fathers intended.
+	fera_silver_damage(target, 5) //Same as silver longsword; it's a solid silver ball. As the founding fathers intended.