Skip to content

Aspcoremvc#11

Open
waynemunro wants to merge 11 commits intoDarqueWarrior:masterfrom
waynemunro:aspcoremvc
Open

Aspcoremvc#11
waynemunro wants to merge 11 commits intoDarqueWarrior:masterfrom
waynemunro:aspcoremvc

Conversation

@waynemunro
Copy link

new generator for ASP.NET core MVC Web Application

@DarqueWarrior
Copy link
Owner

I just took a quick look at the files and your changes look great. I will download the PR and run some test tomorrow or Tuesday and get them merge in.

Great work thank you so much. I will be in touch if I need anything changed.

@DarqueWarrior
Copy link
Owner

Your template folder should not include the lib folder under wwwroot. That is what bower is for.

I am also confused why you have two .bowerrc and bower.json files. One at the root and one in app folder. I did not have to do that with the original .NET Core project.

@waynemunro
Copy link
Author

Thanks you. This is my first PR and appreciate your guidance. I will make the changes as suggested.

The template is based on the project template from Visual Studio 2015 for creating a new ASP.Net Core Web application from within VS. The idea is to be able to git pull code and open the project from VS as well.

@DarqueWarrior
Copy link
Owner

No problem. Well once this is done what we might want to do is simply replace the current asp with this one. By the way I found a bug in 0.2.5 that I am fixing right now that you will have to merge in.

@waynemunro
Copy link
Author

All changed made as requested.

@DarqueWarrior
Copy link
Owner

I assume you are using a Private build agent? I realized this week that our hosted build agents can't build csproj based projects yet. http://www.donovanbrown.com/post/How-to-Rub-DevOps-On-NET-Core-csproj I think we should hold off on changing the project type until you don't have to use a Preview version of dotnet to build it. As you can read in the post you have to have Preview 3 before you can build csproj projects and that is not on Hosted build agents yet.

@waynemunro
Copy link
Author

Oh no, the build definition doesn't use the csproj file, it still used the project.json. The csproj is there to try the project can be opened in locally Visual Studio as well.

I'll wait for the Preview 3. Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants