Skip to content

Restore getModelSessionById usage broken by CV branch merge - #832

Merged
cristian-tamblay merged 1 commit into
developfrom
fix/live-metrics-chart-undefined-session-fetch
Aug 20, 2026
Merged

Restore getModelSessionById usage broken by CV branch merge#832
cristian-tamblay merged 1 commit into
developfrom
fix/live-metrics-chart-undefined-session-fetch

Conversation

@Creylay

@Creylay Creylay commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes a runtime crash (getModelSessionById is not defined) when opening a run's results. An earlier refactor (ca699b142) removed the local getModelSessionById import/fetch from LiveMetricsChart in favor of the modelSessionDetail prop already fetched by the parent, but left a separate isCV check still calling the now-unimported function directly (and synchronously, even though it's async). This block now reuses modelSessionDetail instead of re-fetching the session.


Type of Change

Check all that apply like this [x]:

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

  • DashAI/front/src/components/models/LiveMetricsChart.jsx: replaced the broken isCV useMemo (which called an unimported getModelSessionById synchronously) with a derivation from the already-available modelSessionDetail prop.

Testing

  • Manually verified: opening a run's results (both CV and non-CV sessions) no longer throws and the CV-specific view renders correctly.

@cristian-tamblay
cristian-tamblay merged commit 82fbdc2 into develop Aug 20, 2026
20 checks passed
@cristian-tamblay
cristian-tamblay deleted the fix/live-metrics-chart-undefined-session-fetch branch August 20, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants