Refactor build.sh to be usable as the standard way of building Dasharo coreboot #579
Conversation
Signed-off-by: Filip Gołaś <[email protected]>
philipanda
force-pushed
the
build-script-refactor
branch
from
961fd57 to
ae120f4
Compare
| echo -e "\tnv4x_tgl - build Dasharo for Novacustom NV4x 11 gen" | ||
|
|
||
| echo "Used environmental variables:" | ||
| echo -e "\tCB_REVISION - build Dasharo coreboot from a given revision name" |
There was a problem hiding this comment.
I'm not sure if this should be in this script, if it only checks out a specific rev. For example what happens if it checks out to a revision that doesn't have this script? It may stay in memory and finish the run, but after it finishes the build.sh script may be different and not work the same way if someone calls it again
There was a problem hiding this comment.
That is true. The script is a part of the repository which it would checkout to a different version itself. I wonder if using the script as a universal way of building any version of Dasharo would be possible without making changes in historic revisions...
There was a problem hiding this comment.
Maybe it would be possible to get the ID of the current commit git rev-parse HEAD and restore it after building? This sounds like a cheap solution though...
|
Changed to draft as the refactoring changes were not thoroughly checked and the objective, to make it possible to also build FW for all the NC laptops was not yet achieved |
2 participants
No description provided.