vc/dasharo/options.h: Expose descriptor writeability flag as EFI var #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkopec
force-pushed
the
descriptor_writable_efivar
branch
from
fa49b4a to
2e5d7b2
Compare
miczyg1
reviewed
Sep 1, 2025
mkopec
force-pushed
the
descriptor_writable_efivar
branch
3 times, most recently
from
4829a79 to
8c630bc
Compare
Member
Author
|
V540TU Capsule Update now passes. Needed to remove the HMRFPO disabling code (uncommented, to allow easy re-adding once needed again) |
mkopec
force-pushed
the
descriptor_writable_efivar
branch
4 times, most recently
from
13bba59 to
c50cf49
Compare
Member
Author
|
@SergiiDmytruk is there anything else missing here? |
SergiiDmytruk
previously approved these changes
Sep 2, 2025
Member
There was a problem hiding this comment.
@SergiiDmytruk is there anything else missing here?
No (other than CI), I was doing some tests with QEMU to verify UI updates and update blocking, seems to work as expected.
Contributor
|
FYI: I already bumped edk2 rev here: #762 (it is newer than the one updated here) |
Tested by booting into Ubuntu 24.04 on a NovaCustom V540TU and checking the state of the DescriptorWriteable EFI variable via efivarfs. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Ife03e252f41a58af269f44c8e99e9c627c51c79d Signed-off-by: Michał Kopeć <[email protected]>
Don't issue HMRFPO if Capsule Update is enabled, as HMRFPO causes a global reset which corrupts capsules. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: I2dc0384360c1028d547c572f47f8a767abc61fe2 Signed-off-by: Michał Kopeć <[email protected]>
mkopec
force-pushed
the
descriptor_writable_efivar
branch
from
c50cf49 to
e1c904d
Compare
miczyg1
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see Dasharo/edk2#274