Skip to content

Conversation

@m-iwanicki
Copy link
Contributor

@m-iwanicki m-iwanicki commented Oct 24, 2025

Related: 3mdeb/tui-sh#1
for simplicity I copied tui-lib.sh here.

Left is current DTS, right is DTS with this PR.

Screencast.From.2025-10-24.14-49-20.mp4

Signed-off-by: Michał Iwanicki <[email protected]>
@m-iwanicki m-iwanicki requested a review from DaniilKl October 24, 2025 13:09
@m-iwanicki m-iwanicki self-assigned this Oct 24, 2025
@m-iwanicki m-iwanicki changed the title wip Add tui-sh Oct 24, 2025
This was referenced Oct 24, 2025
@macpijan
Copy link
Contributor

macpijan commented Oct 24, 2025

Nice showcase. The right one certainly does look worse.

@m-iwanicki
Copy link
Contributor Author

m-iwanicki commented Oct 24, 2025

@macpijan and is much, much slower. Another video (kinda hard to see what I'm doing, but I'm testing footer options):

Screencast.From.2025-10-24.15-20-20.mp4

@macpijan
Copy link
Contributor

On which HW this is tested? Can it be reproduced locally on the host machine, something like examples/demo.sh in the tui lib? It was drawing super fast there IIRC.

@m-iwanicki
Copy link
Contributor Author

On which HW this is tested?

That was real DTS running on QEMU, but it should work anywhere you can boot DTS.

@macpijan
Copy link
Contributor

I take it as a no to: Can it be reproduced locally on the host machine, something like examples/demo.sh in the tui lib

@m-iwanicki
Copy link
Contributor Author

I take it as a no to

No, you can't (easily) run it on host machine without building (you need to build one with yq support) and running DTS in QEMU

@iwanicki92
Copy link

iwanicki92 commented Oct 26, 2025

The menu drawing slowdown is due to start_trace_logging. To deal with that we could add

tui_register_refresh_callback stop_trace_logging
tui_register_post_refresh_callback start_trace_logging

Post refresh callbacks would be called after tui_render but before tui_handle_input in tui-lib.sh

@m-iwanicki
Copy link
Contributor Author

The only tests that failed were ones that verify profiles, due to dmidecode changes e.g.:

--- /tmp/robotframework-dts-profile\t2025-10-27 12:14:48.418321347 +0100
+++ "/home/miwanicki/projects/open-source-firmware-validation/dts/profiles/novacustom-v560tnd UEFI Update - DCR.profile"\t2025-10-07 11:28:38.507919190 +0200
@@ -20,8 +20,2 @@
 dmidecode -s bios-version 0
-dmidecode -s system-manufacturer 0
-dmidecode -s system-product-name 0
-dmidecode -s baseboard-product-name 0
-dmidecode -s processor-version 0
-dmidecode -s bios-vendor 0
-dmidecode -s bios-version 0
 flashrom -p internal --flash-name 0
@@ -50 +44,2 @@
 reboot  0
+dmidecode  0
OSFV test results

==============================================================================
Dts-E2E
==============================================================================
Create tests                                                          | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E001: msi-pro-z690-a-ddr5 Initial Deployment - DCR                  | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E002: msi-pro-z690-a-ddr5 Initial Deployment - DPP                  | PASS |
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E003: msi-pro-z690-a-ddr5 UEFI Update - DCR                         | PASS |
------------------------------------------------------------------------------
E2E004: msi-pro-z690-a-ddr5 UEFI Update - DPP                         | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E005: msi-pro-z690-a-ddr5 UEFI->Heads Transition - DPP              | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E006: msi-pro-z690-a-wifi-ddr4 Initial Deployment - DCR             | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E007: msi-pro-z690-a-wifi-ddr4 Initial Deployment - DPP             | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E008: msi-pro-z690-a-wifi-ddr4 UEFI Update - DCR                    | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E009: msi-pro-z690-a-wifi-ddr4 UEFI Update - DPP                    | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E010: msi-pro-z690-a-wifi-ddr4 UEFI->Heads Transition - DPP         | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E011: msi-pro-z790-p-ddr5 Initial Deployment - DPP                  | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E012: msi-pro-z790-p-ddr5 UEFI Update - DPP                         | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E013: msi-pro-z790-p-ddr5 UEFI->Heads Transition - DPP              | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E014: optiplex-7010 Initial Deployment - DPP                        | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E015: optiplex-7010 UEFI Update - DPP                               | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E016: optiplex-9010 Initial Deployment - DPP                        | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E017: optiplex-9010 UEFI Update - DPP                               | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E018: pcengines-apu2 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E019: pcengines-apu2 SeaBIOS Update - DPP                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E020: pcengines-apu2 SeaBIOS->UEFI Transition - DPP                 | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E021: pcengines-apu3 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E022: pcengines-apu3 SeaBIOS Update - DPP                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E023: pcengines-apu3 SeaBIOS->UEFI Transition - DPP                 | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E024: pcengines-apu4 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E025: pcengines-apu4 SeaBIOS Update - DPP                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E026: pcengines-apu4 SeaBIOS->UEFI Transition - DPP                 | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E027: pcengines-apu6 UEFI Update - DPP                              | PASS |
------------------------------------------------------------------------------
E2E028: pcengines-apu6 SeaBIOS Update - DPP                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E029: pcengines-apu6 SeaBIOS->UEFI Transition - DPP                 | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E030: novacustom-nuc_box-125H Initial Deployment - DCR              | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E031: novacustom-nuc_box-155H Initial Deployment - DCR              | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E032: novacustom-v560tu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E033: novacustom-v560tu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E034: novacustom-v560tu UEFI->Heads Transition - DPP                | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E035: novacustom-v560tu Fuse Platform - DCR                         | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E036: novacustom-ns50mu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E037: novacustom-ns50mu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E038: novacustom-ns50pu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E039: novacustom-ns50pu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E040: novacustom-ns70mu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E041: novacustom-ns70mu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E042: novacustom-ns70pu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E043: novacustom-ns70pu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E044: novacustom-nv41mb Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E045: novacustom-nv41mb UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E046: novacustom-nv41mz Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E047: novacustom-nv41mz UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E048: novacustom-nv41pz Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E049: novacustom-nv41pz UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E050: novacustom-nv41pz UEFI->Heads Transition - DPP                | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E051: odroid-h4-plus Initial Deployment - DPP                       | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E052: odroid-h4-plus UEFI Update - DPP                              | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E053: odroid-h4-plus Dasharo (coreboot+UEFI) to Dasharo (Slim Bo... | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E054: odroid-h4-plus Dasharo (Slim Bootloader+UEFI) Initial Depl... | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E055: novacustom-v540tu Initial Deployment - DCR                    | PASS |
------------------------------------------------------------------------------
E2E056: novacustom-v540tu UEFI Update - DCR                           | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E057: novacustom-v540tu UEFI->Heads Transition - DPP                | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
E2E058: novacustom-v540tu Fuse Platform - DCR                         | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E059: novacustom-v540tnd Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E060: novacustom-v540tnd UEFI Update - DCR                          | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E061: novacustom-v560tnd Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E062: novacustom-v560tnd UEFI Update - DCR                          | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
[ WARN ] Workflow isn't configured for profile verification.
E2E063: novacustom-v560tne Initial Deployment - DCR                   | PASS |
------------------------------------------------------------------------------
E2E064: novacustom-v560tne UEFI Update - DCR                          | FAIL |
Teardown failed:
Profiles are not identical!: 1 != 0
------------------------------------------------------------------------------
Dts-E2E                                                               | FAIL |
65 tests, 20 passed, 45 failed
==============================================================================

Signed-off-by: Michał Iwanicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants