-
-
Notifications
You must be signed in to change notification settings - Fork 9
Setup menu color customization #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
philipanda
wants to merge
9
commits into
dasharo
Choose a base branch
from
setup-menu-color-customization
base: dasharo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c990ae5
WIP Make most color values into PCDs
philipanda 3bd024f
MdeModulePkg: Make graphics console colors into PCDs
philipanda 701674c
DasharoPayloadPkg.dsc: Add custom color palette
philipanda 4039cae
MdeModulePkg: Add CustomizedDisplayLib grayed text color pcd
philipanda f37a14f
DasharoPayloadPkg.dsc: Add CustomizedDisplayLib grayed text pcd
philipanda 883993c
DasharoPaloadPkg.dsc: Adjust text colors
philipanda 145ff2b
DasharoColorTheme.dsc.inc: Move color theme to a file
philipanda ed696ff
DasharoColorTheme.dsc.inc: Add comments describing colors
philipanda 2473d00
TerminalDxe: Use PCD color schemes & 24b colors in terminal
philipanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Color codes defined at MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | ||
| # Foregrounds: | ||
| # 0x00 (EFI_BLACK) | ||
| # 0x01 (EFI_BLUE) | ||
| # 0x02 (EFI_GREEN) | ||
| # 0x03 (EFI_CYAN) | ||
| # 0x04 (EFI_RED) | ||
| # 0x05 (EFI_MAGENTA) | ||
| # 0x06 (EFI_BROWN) | ||
| # 0x07 (EFI_LIGHTGRAY) | ||
| # 0x08 (EFI_DARKGRAY) | ||
| # 0x09 (EFI_LIGHTBLUE) | ||
| # 0x0A (EFI_LIGHTGREEN) | ||
| # 0x0B (EFI_LIGHTCYAN) | ||
| # 0x0C (EFI_LIGHTRED) | ||
| # 0x0D (EFI_LIGHTMAGENTA) | ||
| # 0x0E (EFI_YELLOW) | ||
| # 0x0F (EFI_WHITE) | ||
| # | ||
| # Backgrounds: | ||
| # 0x00 (EFI_BACKGROUND_BLACK) | ||
| # 0x10 (EFI_BACKGROUND_BLUE) | ||
| # 0x20 (EFI_BACKGROUND_GREEN) | ||
| # 0x30 (EFI_BACKGROUND_CYAN) | ||
| # 0x40 (EFI_BACKGROUND_RED) | ||
| # 0x50 (EFI_BACKGROUND_MAGENTA) | ||
| # 0x60 (EFI_BACKGROUND_BROWN) | ||
| # 0x70 (EFI_BACKGROUND_LIGHTGRAY) | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldBackgroundHighlightColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextHighlightColor|0x0F # White text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserTitleBackgroundColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserTitleTextColor|0x0F # White text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPopupBackgroundColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPopupTextColor|0x0F # White text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPopupInverseTextColor|0x06 # Grey text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPopupInverseBackgroundColor|0x06 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserHelpTextColor|0x07 # Light grey text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserHelpBackgroundColor|0x30 # White bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserInfoTextColor|0x06 # Grey text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserInfoBackgroundColor|0x30 # White bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x06 # Grey text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldBackgroundColor|0x30 # White bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x02 # Green text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserBannerBackgroundColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserBannerTextColor|0x0F # White text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserKeyHelpTextColor|0x02 # Green text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserKeyHelpBackgroundColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPickListTextColor|0x06 # Grey text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserPickListBackgroundColor|0x30 # White bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserArrowTextColor|0x0F # White text | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserArrowBackgroundColor|0x60 # Grey bg | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldGrayedTestColor|0x07 # Light grey text | ||
|
|
||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteBlack | { 0x00, 0x00, 0x00, 0x00 } # 0 Plain black | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLightBlue | { 0x00, 0x00, 0x00, 0x98 } # 1 Dark green | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLightGreen | { 0x00, 0x38, 0xD4, 0x30 } # 2 Dasharo green | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLightCyan | { 0x00, 0xFF, 0xFF, 0xFF } # 3 White | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLightRed | { 0x00, 0x98, 0x00, 0x00 } # 4 Red | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteMagenta | { 0x00, 0x98, 0x00, 0x98 } # 5 Magenta | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteBrown | { 0x00, 0x29, 0x36, 0x3b } # 6 Dasharo grey | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLightGray | { 0x00, 0x80, 0x80, 0x80 } # 7 Light grey | ||
|
|
||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteDarkGray | { 0x00, 0x30, 0x30, 0x30 } # 00 Dark grey | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteBlue | { 0x00, 0x00, 0x00, 0xFF } # 10 Blue | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteLime | { 0x00, 0x00, 0xFF, 0x00 } # 20 Green | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteCyan | { 0x00, 0xFF, 0xFF, 0x00 } # 30 Cyan | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteRed | { 0x00, 0xFF, 0x00, 0x00 } # 40 Red | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteFuchsia | { 0x00, 0xFF, 0x00, 0xFF } # 50 Fuchsia | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteYellow | { 0x00, 0xFF, 0xFF, 0x00 } # 60 Yellow | ||
| gEfiMdeModulePkgTokenSpaceGuid.PcdGraphicsConsoleColorPaletteWhite | { 0x00, 0xFF, 0xFF, 0xFF } # 70 White |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipanda another mistakenly added change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. I've commited some random files before too. I think that I'm commiting some artifacts from the build process that I am unaware of. I certainly did not search&replaced something in a binary file 😆. I'll check twice before adding a whole directory next time.