Skip to content

Conversation

DaniilKl
Copy link
Contributor

@DaniilKl DaniilKl commented Jul 9, 2025

No description provided.

@DaniilKl DaniilKl requested a review from m-iwanicki July 9, 2025 09:35
@DaniilKl DaniilKl self-assigned this Jul 9, 2025
@DaniilKl DaniilKl force-pushed the add-custom-ipxe-server-docs branch from 4fb95c7 to cb346e2 Compare July 9, 2025 09:36
From now the `dts.ipxe` can be used via iPXE shell by typing:
```text
chain http://IP:8080/dts.ipxe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chain http://IP:8080/dts.ipxe
chain http://localhost:8080/dts.ipxe

and :4321 if you use script. Not sure if this step is even needed, and you assume reader knows where to write this chain command

Copy link
Contributor Author

@DaniilKl DaniilKl Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why localhost? Are you launching the server on the same hardware, where you are booting the files from the server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you assume reader knows where to write this chain command

I assume the user knows what is the iPXE shell.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you launching the server on the same hardware, where you are booting the files from the server?

Yes? How else are you running E2E tests?

Copy link
Contributor Author

@DaniilKl DaniilKl Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, for E2E it is ok, but I had have been using it for testing on hardware too.

Copy link
Contributor

@m-iwanicki m-iwanicki Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then fix documentation? This setup is for E2E tests:

## E2E tests

(...)

### HTTP server with DTS iPXE boot

This subsection is under E2E tests.

Remove one #, and mention that you can use localhost when referencing in E2E section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you are right

@DaniilKl DaniilKl requested a review from m-iwanicki July 9, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants