Skip to content

Conversation

@fboulnois
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-2471

Summary

Upgrades from ElasticSearch 5 to OpenSearch 3. Here's what is needed in the docker-compose.yaml:

  elastic:
    image: opensearchproject/opensearch:3
    ports:
      - "9200:9200"
    container_name: elastic
    volumes:
      - ./data:/usr/share/opensearch/data
    environment:
      - DISABLE_SECURITY_PLUGIN=true
      - discovery.type=single-node
      - cluster.routing.allocation.disk.threshold_enabled=false

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment


public InputStream searchDatasetsStream(String query) throws IOException {
if (!validateQuery(query)) {
if (invalidResultWindow(query)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /_validate/query endpoint can only validate the query part, but if you have aggregations this marks the query as invalid, hence for the v2 endpoint only the result window size is checked.

@fboulnois fboulnois marked this pull request as ready for review December 3, 2025 18:17
@fboulnois fboulnois requested a review from a team as a code owner December 3, 2025 18:17
@fboulnois fboulnois requested review from eweitz and otchet-broad and removed request for a team December 3, 2025 18:17
@fboulnois fboulnois force-pushed the fb-dt-2471-opensearch-3-upgrade branch from a712cae to 7ba4e2c Compare December 4, 2025 15:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

@otchet-broad
Copy link
Contributor

@fboulnois - Had you given any more thought to how we might migrate to this and have both running at the same time?

What's in this PR looks great for the cutover, but it necessitates an all-in migration where both the FE and BE need to convert simultaneously. I wasn't sure where that topic landed.

Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice consistency in the port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants