Skip to content

Conversation

@kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Dec 5, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-2527

Summary

This PR adds migrations for IntellectualProperty, Presentations, and Publications in Data Access Requests whose models have been modified for S4R.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Dec 5, 2025
@kevinmarete kevinmarete marked this pull request as ready for review December 5, 2025 22:39
@kevinmarete kevinmarete requested a review from a team as a code owner December 5, 2025 22:39
@kevinmarete kevinmarete requested review from eweitz and otchet-broad and removed request for a team December 5, 2025 22:39
Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
To help by independently testing, I cloned the dev database, ran it locally, and was able to look at one of the problematic DARs.

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments as you see fit 👍🏽

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@kevinmarete kevinmarete merged commit 0559be8 into develop Dec 9, 2025
15 of 17 checks passed
@kevinmarete kevinmarete deleted the km_DT-2527_fix_data_collection_failure branch December 9, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants