Skip to content

Conversation

@kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Dec 11, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-2561

Summary

This PR standardizes the use of the attribute intellectualProperty in DARs. There has been inconsistent use of both intellectualProperty and intellectualProperties. We have settled on intellectualProperties.

It also fixes the IntellectualProperty model by removing the date attribute and changing the filingDate attribute from Boolean to String.


Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Dec 11, 2025
@sonarqubecloud
Copy link

@kevinmarete kevinmarete marked this pull request as ready for review December 11, 2025 20:43
@kevinmarete kevinmarete requested a review from a team as a code owner December 11, 2025 20:43
@kevinmarete kevinmarete requested review from eweitz and rushtong and removed request for a team December 11, 2025 20:43
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this will definitely be less confusing going forward 👍🏽

AND data -> 'intellectualProperties' IS NULL;
</sql>
</changeSet>
</databaseChangeLog> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit - could use a newline here.

Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thank you!

Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice consistency refinement!

@kevinmarete kevinmarete merged commit 820d25b into develop Dec 11, 2025
14 checks passed
@kevinmarete kevinmarete deleted the km_DT-2561_update_intellectual_property branch December 11, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants