-
Notifications
You must be signed in to change notification settings - Fork 2
[DT-2561] Rename intellectualProperty to intellectualProperties
#2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rushtong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this will definitely be less confusing going forward 👍🏽
| AND data -> 'intellectualProperties' IS NULL; | ||
| </sql> | ||
| </changeSet> | ||
| </databaseChangeLog> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit - could use a newline here.
otchet-broad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you!
eweitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice consistency refinement!



Addresses
https://broadworkbench.atlassian.net/browse/DT-2561
Summary
This PR standardizes the use of the attribute intellectualProperty in DARs. There has been inconsistent use of both
intellectualPropertyandintellectualProperties. We have settled onintellectualProperties.It also fixes the
IntellectualPropertymodel by removing thedateattribute and changing thefilingDateattribute fromBooleantoString.Have you read CONTRIBUTING.md lately? If not, do that first.