[DT-2750] Erase old study properties before applying new registration to a study. #2770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration to a study.
otchet-broad
commented
Dec 15, 2025
| Optional<StudyProperty> updatedProp1 = | ||
| updatedStudy.getProperties().stream() | ||
| .filter(p -> p.getStudyPropertyId().equals(prop1.getStudyPropertyId())) | ||
| .filter(p -> p.getKey().equals(prop1.getKey())) |
Contributor
Author
There was a problem hiding this comment.
Since we're deleting and reinserting the property now, the ID can change. Using the property Key ensures that we're finding the property we expect.
otchet-broad
changed the title
otchet-broad
requested review from
kevinmarete and
rushtong
and removed request for
a team
kevinmarete
approved these changes
Dec 15, 2025
rushtong
approved these changes
Dec 15, 2025
Contributor
rushtong
left a comment
rushtong
left a comment
There was a problem hiding this comment.
Minor comment inline, address as you see fit. 👍🏽
Co-authored-by: Gregory Rushton <[email protected]>
|
otchet-broad
deleted the
otchet-dt-2750-erase-old-properties-before-registration-based-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-2750
Summary
Removes all study properties when receiving a new registration for a study. This allows patching to work for a particular study property through the new patch endpoint, but cleans up old study properties that may no longer be relevant when submitting a new registration and applying it to an existing study.
Have you read CONTRIBUTING.md lately? If not, do that first.