AN-649 Remove Azure Code, Round 1#4866
Conversation
|
Temporarily changing base to run tests, will need to change back to |
aednichols
left a comment
aednichols
left a comment
There was a problem hiding this comment.
I did a cursory review of the changed files and everything seems reasonable.
I trust our compiler and tests on this one, the code was pretty modular and cleanly excised.
| def tclExclusions(m: ModuleID): ModuleID = m.excludeAll(excludeSpringBoot, excludeSpringAop, excludeSpringData, excludeSpringFramework, excludeOpenCensus, excludeGoogleFindBugs, excludeBroadWorkbench, excludePostgresql, excludeSnakeyaml, excludeSlf4j, excludeCommonsText, excludeLiquibase, excludeOpenTelemetry, excludeFlagsmith) | ||
| val workspaceManager = excludeJakarta("bio.terra" % "workspace-manager-client" % workSpaceManagerV) | ||
| val bpm = excludeJakarta("bio.terra" % "billing-profile-manager-client" % bpmV) | ||
| def tclExclusions(m: ModuleID): ModuleID = m.excludeAll(excludeSpringBoot, excludeSpringAop, excludeSpringData, excludeSpringFramework, excludeOpenCensus, excludeGoogleFindBugs, excludeBroadWorkbench, excludePostgresql, excludeSnakeyaml, excludeSlf4j, excludeCommonsText, excludeLiquibase, excludeFlagsmith) |
There was a problem hiding this comment.
Un-excluding opentelemetry from TCL - looks like it was coming in via BPM before. This resolves the NoClassDefFound errors I saw after removing WSM and BPM client libraries.
lucymcnatt
left a comment
lucymcnatt
left a comment
There was a problem hiding this comment.
Generally looks good! Just left a few questions on what was removed vs. not
| implicit val createAppDecoder: Decoder[CreateAppRequest] = | ||
| Decoder.instance { x => | ||
| for { | ||
| c <- x.downField("kubernetesRuntimeConfig").as[Option[KubernetesRuntimeConfig]] |
There was a problem hiding this comment.
just a nit since I know this is moved from elsewhere, I've never been a big fan of the acronym/letter vars here...
| } | ||
| } | ||
|
|
||
| it should "list runtimes v2 with a workspace" in { |
There was a problem hiding this comment.
if we're keeping around listRuntimeV2, should we also keep the tests?
There was a problem hiding this comment.
Yes, I'll double-check this - there were two listRuntime methods, one with workspace and one without, and we kept only the no-workspace one.
…leonardo into jd_AN-649_removeAzureCode
lucymcnatt
left a comment
lucymcnatt
left a comment
There was a problem hiding this comment.
LGTM! Thanks for taking on this huge cleanup
3 participants
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-649
Summary of changes
Round 1 of ripping out all Azure support code. The focus of this changeset is removing all the code that actually does things on Azure. In Round 2 (or maybe 3), we'll remove all the unused database tables and fully strip Azure concerns from the codebase.
Open question: should we take out app update functionality?
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.