Skip to content

[CTM-538] Add to allowlist for SCP tools in Terra Jupyter notebooks#4911

Merged
eweitz merged 3 commits into
developfrom
ew-ctm-538-scp-csp
Jun 15, 2026
Merged

[CTM-538] Add to allowlist for SCP tools in Terra Jupyter notebooks#4911
eweitz merged 3 commits into
developfrom
ew-ctm-538-scp-csp

Conversation

@eweitz

@eweitz eweitz commented Jun 10, 2026

Copy link
Copy Markdown
Member

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-538

Summary of changes

This enables Single Cell Portal visualization tools in Jupyter notebooks on Terra, supporting a BioData Catalyst grant.

As described in the AppSec review, this adds some origins to the Content Security Policy allowlist on Terra. These CSP entries are needed by SCP tools like Gene Leads.

Here's a video demo:

Gene_Leads_in_Terra_dev_Jupyter_notebook__SCP_tools_in_BDC-Terra__2026-06-10.mov

Testing these changes

If you manually deploy this branch to leonardo dev, ensure you set leonardo dev back to develop Git branch before the end of the day!

Ensure this branch is deployed on leonardo dev:

  1. Go to https://beehive.dsp-devops-prod.broadinstitute.org/environments/dev/chart-releases/leonardo/change-versions
  2. Search for "the most recent from specified branch ew-ctm-538-scp-csp." If found, go to "If this branch is deployed on leonardo dev" steps below.
  3. If not found, in "Specify App Version" in middle column, click "Git branch"
  4. In right column, click "ew-ctm-538-scp-csp"
  5. Back in middle column, confirm "ew-ctm-538-scp-csp" is set in "Set Git Branch" section
  6. Click "Click to Refresh and Preview Changes" at bottom in middle column
  7. In subsequent view, click "Apply 1 Change" at left

If this branch is deployed on leonardo dev:

  1. Go to https://bvdp-saturn-dev.appspot.com/#workspaces/general-dev-billing-account/scp-bdc-terra-dev/analyses.
  2. Open the Jupyter Notebook for Gene Leads.
  3. Execute the code cells.
  4. Confirm the ideogram loads.
  5. Hover over a gene triangle and confirm that expression-by-tissue curves appear, and that RNA and protein domain models also appear.

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@eweitz eweitz requested a review from a team as a code owner June 10, 2026 15:13
@eweitz eweitz marked this pull request as draft June 10, 2026 19:10
@eweitz eweitz marked this pull request as ready for review June 10, 2026 19:46
@eweitz eweitz marked this pull request as draft June 10, 2026 19:49
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (82eae55) to head (60157b7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4911   +/-   ##
========================================
  Coverage    74.07%   74.07%           
========================================
  Files          131      131           
  Lines        11101    11101           
  Branches       891      891           
========================================
  Hits          8223     8223           
  Misses        2878     2878           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82eae55...60157b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eweitz eweitz marked this pull request as ready for review June 11, 2026 13:50

@LizBaldo LizBaldo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the thorough Appsec review and Beehive testing!

@eweitz eweitz enabled auto-merge (squash) June 15, 2026 20:25
@eweitz eweitz merged commit 9fcabd8 into develop Jun 15, 2026
15 checks passed
@eweitz eweitz deleted the ew-ctm-538-scp-csp branch June 15, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants