[CTM-525] new workbench-libs and update ember#4912
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4912 +/- ##
===========================================
- Coverage 74.08% 74.07% -0.01%
===========================================
Files 131 131
Lines 11100 11101 +1
Branches 902 891 -11
===========================================
Hits 8223 8223
- Misses 2877 2878 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
LizBaldo
approved these changes
Jun 15, 2026
LizBaldo
left a comment
Collaborator
There was a problem hiding this comment.
Agree we can ignore the code cov error
aednichols
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-525
Summary of changes
Leonardo updated its
workbench-libsdependency to the to get http4s upgraded from 1.0.0-M38 to 1.0.0-M45. Sincehttp4s-prometheus-metricsstops publishing at M38, it is pinned at that version with a libraryDependencySchemes override to suppress the eviction error. The newLoggerFactory[F]requirement fromemberandhttp4sM45's Retry middleware was satisfied by injecting a Slf4jFactory-derived implicit at the relevant call sites in production and test code.Note: I think the codecov failure can be safely ignored - do you agree, reviewer?
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.