[Fleet Automation] Add a flag to force install package #31712

julien-lebot · 2024-12-03T15:27:15Z

What does this PR do?

This PR adds a flag that allows ignoring if a package is installed and the version matches in the InstallPackage command.

Motivation

https://datadoghq.atlassian.net/browse/WINA-1170

Describe how you validated your changes

Run install script to install 7.56. Remote update to 7.58. Re-run install script with 7.56. Agent version should be 7.56.

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-12-03T15:43:43Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54444036 --os-family=ubuntu

Note: This applies to commit 43a5675

cit-pr-commenter · 2024-12-03T16:11:03Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d2caddac-160c-44ae-b4ff-3fcc493961f5

Baseline: 01c8fb0
Comparison: 43a5675
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.52	[-1.55, +4.59]	1	Logs
➖	quality_gate_idle	memory utilization	+0.55	[+0.52, +0.59]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.54	[+0.48, +0.59]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.28	[+0.22, +0.35]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.10	[-0.67, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.08	[-0.85, +1.00]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.78, +0.79]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.29, +0.29]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.00	[-0.79, +0.78]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.01	[-0.65, +0.64]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.92, +0.86]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.92, +0.81]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.20	[-0.68, +0.27]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.35	[-1.25, +0.54]	1	Logs
➖	file_tree	memory utilization	-0.48	[-0.54, -0.42]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http1	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-01-20T16:56:51Z

Gitlab CI Configuration Changes

Modified Jobs

deploy_installer_packages_windows-x64

  deploy_installer_packages_windows-x64:
    before_script:
    - ls $OMNIBUS_PACKAGE_DIR
+   - ls $WINDOWS_POWERSHELL_DIR
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - windows-installer-amd64
    - powershell_script_signing
    rules:
    - if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
    script:
    - $S3_CP_CMD --recursive --exclude "*" --include "datadog-installer-*-1-x86_64.msi"
      --include "datadog-installer-*-1-x86_64.debug.zip" --include "datadog-installer-*-1-x86_64.zip"
      --include "datadog-installer-*-1-x86_64.exe" $OMNIBUS_PACKAGE_DIR $S3_RELEASE_INSTALLER_ARTIFACTS_URI/msi/x86_64/
    - $S3_CP_CMD $WINDOWS_POWERSHELL_DIR/Install-Datadog.ps1 $S3_RELEASE_INSTALLER_ARTIFACTS_URI/scripts/Install-Datadog.ps1
    stage: deploy_packages
    tags:
    - arch:amd64

new-e2e-installer-windows

  new-e2e-installer-windows:
    after_script:
    - $CI_PROJECT_DIR/tools/ci/junit_upload.sh
    artifacts:
      expire_in: 2 weeks
      paths:
      - $E2E_OUTPUT_DIR
      - junit-*.tgz
      reports:
        annotations:
        - $EXTERNAL_LINKS_PATH
      when: always
    before_script:
    - CURRENT_AGENT_VERSION=$(invoke agent.version) || exit $?; export CURRENT_AGENT_VERSION
    - export STABLE_AGENT_VERSION_PACKAGE=$(curl --retry 10 --retry-all-errors -sS https://hub.docker.com/v2/namespaces/datadog/repositories/agent-package/tags
      | jq -r '.results[] | .name' | sort | tail -n 2 | head -n 1)
    - export STABLE_INSTALLER_VERSION_PACKAGE=$(curl --retry 10 --retry-all-errors -sS
      https://hub.docker.com/v2/namespaces/datadog/repositories/installer-package/tags
      | jq -r '.results[] | .name' | sort | tail -n 2 | head -n 1)
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_e2e.tar.xz -C $GOPATH/pkg/mod/cache
      || exit 101
    - rm -f modcache_e2e.tar.xz
    - mkdir -p ~/.aws
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config
      || exit $?
    - export AWS_PROFILE=agent-qa-ci
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
      $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
      || exit $?
    - touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
      $AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
    - pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
    - ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
      || exit $?; export ARM_CLIENT_ID
    - ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
      || exit $?; export ARM_CLIENT_SECRET
    - ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
      || exit $?; export ARM_TENANT_ID
    - ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
      || exit $?; export ARM_SUBSCRIPTION_ID
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
      || exit $?
    - export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
    - inv -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
    image: registry.ddbuild.io/ci/test-infra-definitions/runner$TEST_INFRA_DEFINITIONS_BUILDIMAGES_SUFFIX:$TEST_INFRA_DEFINITIONS_BUILDIMAGES
    needs:
    - go_e2e_deps
    - deploy_windows_testing-a7
    - deploy_installer_oci
    - deploy_agent_oci
+   - qa_installer_script_windows
    parallel:
      matrix:
      - EXTRA_PARAMS: --run "TestAgentInstallsWithAgentUser$"
      - EXTRA_PARAMS: --run "TestAgentInstalls$"
      - EXTRA_PARAMS: --run "TestAgentUpgrades$"
+     - EXTRA_PARAMS: --run "TestInstallScript$"
      - EXTRA_PARAMS: --run "TestInstallScriptWithAgentUser$"
      - EXTRA_PARAMS: --run "TestInstaller$"
      - EXTRA_PARAMS: --run "TestInstallerRollback$"
      - EXTRA_PARAMS: --run "TestInstallerSystemIntegrity$"
      - EXTRA_PARAMS: --run "TestInstallerUpgrades$"
    rules:
    - if: $RUN_E2E_TESTS == "off"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $RUN_E2E_TESTS == "on"
      when: on_success
    - if: $CI_COMMIT_BRANCH == "main"
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: on_success
    - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
      when: on_success
    - changes:
        compare_to: main
        paths:
        - .gitlab/e2e/e2e.yml
        - test/new-e2e/pkg/**/*
        - test/new-e2e/go.mod
        - flakes.yaml
    - changes:
        compare_to: main
        paths:
        - .gitlab/**/*
        - omnibus/config/**/*
        - pkg/fleet/**/*
        - cmd/installer/**/*
        - test/new-e2e/tests/installer/**/*
        - tasks/installer.py
      when: on_success
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - allow_failure: true
      when: manual
    script:
    - inv -e new-e2e-tests.run --targets $TARGETS -c ddagent:imagePullRegistry=669783387624.dkr.ecr.us-east-1.amazonaws.com
      -c ddagent:imagePullUsername=AWS -c ddagent:imagePullPassword=$(aws ecr get-login-password)
      --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer --logs-folder=$E2E_OUTPUT_DIR/logs
      --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
    stage: e2e
    tags:
    - arch:amd64
    variables:
      E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
      E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
      E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
      E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
      E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
      E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
      E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
      E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
      E2E_LOGS_PROCESSING_TEST_DEPTH: 1
      E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
      E2E_PIPELINE_ID: $CI_PIPELINE_ID
      EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
      FLEET_INSTALL_METHOD: windows
      KUBERNETES_CPU_REQUEST: 6
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 12Gi
      SHOULD_RUN_IN_FLAKES_FINDER: 'true'
      TARGETS: ./tests/installer/windows
      TEAM: fleet

powershell_script_signing

  powershell_script_signing:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $WINDOWS_POWERSHELL_DIR
    needs: []
    rules:
-   - if: $DEPLOY_INSTALLER == "true" || $DDR_WORKFLOW_ID != null
+   - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
+     when: never
+   - when: on_success
    script:
    - mkdir $WINDOWS_POWERSHELL_DIR
    - docker run --rm -v "$(Get-Location):c:\mnt" -e AWS_NETWORKING=true -e IS_AWS_CONTAINER=true
      ${WINBUILDIMAGE} powershell -C "dd-wcs sign \mnt\tools\windows\DatadogAgentInstallScript\Install-Datadog.ps1"
    - copy .\tools\windows\DatadogAgentInstallScript\Install-Datadog.ps1 $WINDOWS_POWERSHELL_DIR\Install-Datadog.ps1
-   stage: deploy_packages
+   stage: package_build
    tags:
    - runner:windows-docker
    - windowsversion:2022
    variables:
      ARCH: x64
      WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:${DATADOG_AGENT_WINBUILDIMAGES}

Added Jobs

qa_installer_script_windows

qa_installer_script_windows:
  before_script:
  - ls $WINDOWS_POWERSHELL_DIR
  image: registry.ddbuild.io/ci/datadog-agent-buildimages/gitlab_agent_deploy$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
  needs:
  - powershell_script_signing
  rules:
  - if: $RUN_E2E_TESTS == "off"
    when: never
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - if: $RUN_E2E_TESTS == "on"
    when: on_success
  - if: $CI_COMMIT_BRANCH == "main"
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    when: on_success
  - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
    when: on_success
  - changes:
      compare_to: main
      paths:
      - .gitlab/e2e/e2e.yml
      - test/new-e2e/pkg/**/*
      - test/new-e2e/go.mod
      - flakes.yaml
  - changes:
      compare_to: main
      paths:
      - .gitlab/**/*
      - omnibus/config/**/*
      - pkg/fleet/**/*
      - cmd/installer/**/*
      - test/new-e2e/tests/installer/**/*
      - tasks/installer.py
    when: on_success
  - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
    when: never
  - allow_failure: true
    when: manual
  script:
  - $S3_CP_CMD $WINDOWS_POWERSHELL_DIR/Install-Datadog.ps1 s3://${INSTALLER_TESTING_S3_BUCKET}/${CI_PIPELINE_ID}/scripts/Install-Datadog.ps1
  stage: deploy_packages
  tags:
  - arch:amd64

Changes Summary

Removed	Modified	Added	Renamed
0	3	1	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2025-01-20T18:00:06Z

Uncompressed package size comparison

Comparison with ancestor 01c8fb06949e0297bfe5401b36b6ad97a4c5088a

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	911.85MB	911.85MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	921.59MB	921.59MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	921.59MB	921.59MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	899.25MB	899.25MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.01MB	59.01MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.09MB	59.09MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.09MB	59.09MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.50MB	56.50MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	477.81MB	477.81MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	93.80MB	93.80MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	93.87MB	93.87MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	93.87MB	93.87MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	89.87MB	89.87MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	89.94MB	89.94MB	0.50MB
datadog-agent-aarch64-rpm	-0.00MB	✅	908.97MB	908.97MB	0.50MB

Decision

✅ Passed

julien-lebot · 2025-01-22T17:09:34Z

test/new-e2e/tests/installer/windows/base_suite.go

 //	E2E_PIPELINE_ID=40537701;
 //	CURRENT_AGENT_VERSION=7.57.0-devel+git.370.d429ae3;
 //	STABLE_INSTALLER_VERSION_PACKAGE=7.56.0-installer-0.4.6-1-1
 //	STABLE_AGENT_VERSION_PACKAGE=7.55.2-1
-type BaseInstallerSuite struct {
+type BaseSuite struct {


This was renamed to distinguish the 2 similarly named baseInstallerSuite and BaseInstallerSuite.

julien-lebot · 2025-01-22T17:10:01Z

test/new-e2e/tests/installer/windows/suites/installer-package/base_installer_package_suite.go

-type baseInstallerSuite struct {
-	installerwindows.BaseInstallerSuite
+// baseInstallerPackageSuite is the base test suite for tests of the installer MSI
+type baseInstallerPackageSuite struct {


See https://github.com/DataDog/datadog-agent/pull/31712/files#r1925680212

…o msiexec)

julien-lebot · 2025-02-03T10:58:55Z

Closing in favor of #33600

julien-lebot added os/windows team/windows-agent qa/done QA done before merge and regressions are covered by tests labels Dec 3, 2024

julien-lebot added this to the Triage milestone Dec 3, 2024

julien-lebot requested review from a team as code owners December 3, 2024 15:27

github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 3, 2024

julien-lebot force-pushed the julien.lebot/fleet_automation/WINA-1170 branch from 25dc535 to 60c461a Compare January 17, 2025 12:04

julien-lebot changed the title ~~[Fleet Automation] Don't check version of installed package when installing~~ [Fleet Automation] Add a flag to force install package Jan 17, 2025

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 17, 2025

julien-lebot force-pushed the julien.lebot/fleet_automation/WINA-1170 branch from 60c461a to 437bdba Compare January 17, 2025 17:42

julien-lebot requested review from a team as code owners January 20, 2025 16:54

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 20, 2025

julien-lebot added the changelog/no-changelog label Jan 20, 2025

julien-lebot force-pushed the julien.lebot/fleet_automation/WINA-1170 branch from b938773 to cb5efe5 Compare January 20, 2025 17:37

julien-lebot commented Jan 22, 2025

View reviewed changes

julien-lebot added 3 commits January 29, 2025 13:14

Don't check version of installed package when installing

617f870

Correctly tag args

ef6db69

Use a flag to force installing even if the version already exists

27c30d5

julien-lebot added 20 commits January 29, 2025 13:15

Try with URL at the end of the command

6a53027

Only pass the force flag if it's true

dd53bd2

Fix blank space issue

e15636a

Move preinst to the correct location

df8a270

Fix linter

0dd3740

Refactor E2E tests

001b628

Further refactoring

ab59216

Add testInstallScript to CI

cf3d5de

Fix compilation and finish remaining E2E tests

a446abd

Fix import cycle

4af43bd

Prefer pipeline ID

77ec3b1

Fix names

dc40056

Add missing const package

2817c1b

FIx options

e006a48

Add missing comment package

ee31671

FIx tests by appropriately creating the necessary folders

12cf551

Add exit code to install script

d5fd43d

Boolean flag doesn't support true / false

3afe060

Re-arrange the flags

9e3987c

Fix argument passing

5c119b5

julien-lebot force-pushed the julien.lebot/fleet_automation/WINA-1170 branch from 046c6d0 to 5c119b5 Compare January 29, 2025 12:15

julien-lebot added 7 commits January 29, 2025 14:52

Fix E2E tests

60df69e

gofmt

8e09683

Use Administrative install to bootstrap new installer (and fix call t…

6642c25

…o msiexec)

Try to use SysProcAttr to format command line manually

b15e224

Fix compilation on Linux

43fa7bc

no message

768ddb6

Use correct environment variables

43a5675

julien-lebot closed this Feb 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet Automation] Add a flag to force install package #31712

[Fleet Automation] Add a flag to force install package #31712

julien-lebot commented Dec 3, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 3, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 3, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

agent-platform-auto-pr bot commented Jan 20, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 20, 2025 •

edited

Loading

julien-lebot Jan 22, 2025

julien-lebot Jan 22, 2025

julien-lebot commented Feb 3, 2025

[Fleet Automation] Add a flag to force install package #31712

[Fleet Automation] Add a flag to force install package #31712

Conversation

julien-lebot commented Dec 3, 2024 • edited Loading

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Dec 3, 2024 • edited Loading

Test changes on VM

cit-pr-commenter bot commented Dec 3, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Jan 20, 2025 • edited Loading

Gitlab CI Configuration Changes

Modified Jobs

Added Jobs

Changes Summary

agent-platform-auto-pr bot commented Jan 20, 2025 • edited Loading

Uncompressed package size comparison

Decision

julien-lebot Jan 22, 2025

Choose a reason for hiding this comment

julien-lebot Jan 22, 2025

Choose a reason for hiding this comment

julien-lebot commented Feb 3, 2025

julien-lebot commented Dec 3, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 3, 2024 •

edited

Loading

cit-pr-commenter bot commented Dec 3, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Jan 20, 2025 •

edited

Loading

agent-platform-auto-pr bot commented Jan 20, 2025 •

edited

Loading