Assorted small fixes for dogstatsd UDS listener. #33582
Open
+107
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produce more verbose error message when EOF happens after reading some bytes, but not all, as it indictates connection sync error. Also log all other errors and treat them as fatal.
SCM_CREDENTIALS are always written in full from the start for each read, even if the previous was partial (which shouldn't happen in our case).
Read returns number of bytes read by that one particular call, not the final position in the buffer. Reusing only the previous return value will overwrite previously received data. If reads sufficiently small, number of bytes read may never be equal to expectedPacketLength, causing the loop to never complete.
vickenty
added
changelog/no-changelog
qa/done
vickenty
changed the title
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=54456568 --os-family=ubuntuNote: This applies to commit 78e9185 |
tobz
approved these changes
Jan 30, 2025
|
|
||
| for err := range sync { | ||
| require.NoError(t, err) | ||
| time.Sleep(10 * time.Millisecond) |
There was a problem hiding this comment.
Just a small nit: what's the reason to be adding a sleep here?
remeh
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix assorted small issues in dogstatsd uds listener.
Motivation
Improve error reporting and fix potential issues with partial reads from stream socket.
Describe how you validated your changes
New test added to cover the correctness issue with partial read.
Possible Drawbacks / Trade-offs
Additional Notes