Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.63.x] [ASCII-2691] Change wording on FIPS Mode status indication #33592

Open
wants to merge 3 commits into
base: 7.63.x
Choose a base branch
from

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport 517df3f from #33507.


<!--

  • Contributors are encouraged to read our CONTRIBUTING documentation.
  • Both Contributor and Reviewer Checklists are available at https://datadoghq.dev/datadog-agent/guidelines/contributing/#pull-requests.
  • The pull request:
    • Should only fix one issue or add one feature at a time.
    • Must update the test suite for the relevant functionality.
    • Should pass all status checks before being reviewed or merged.
  • Commit titles should be prefixed with general area of pull request's change.
  • Please fill the below sections if possible with relevant information or links.
    -->

What does this PR do?

This PR modifies the wording added in #33287 and supports a status indicator for the normal datadog-agent build re: FIPS Mode and if it is running in proxy status.

datadog-agent without the fips-proxy configured:
<img width="713" alt="regular agent" src="https://github.com/user-attachments/assets/f111cd3b-8e88-426b-a5ae-2e2cb74c5ca8" />

datadog-agent with the fips-proxy configured:
<img width="702" alt="regular agent fips-proxy" src="https://github.com/user-attachments/assets/cb9aab09-1592-4ead-b105-8aadf3bf3848" />

datadog-fips-agent without GOFIPS set:
<img width="656" alt="fips agent GOFIPS=0" src="https://github.com/user-attachments/assets/8b8fbc4a-724a-4d44-a6bd-430f17ed92d9" />

datadog-fips-agent with GOFIPS set:
<img width="651" alt="datadog-fips-agent" src="https://github.com/user-attachments/assets/d3b90a0f-8295-403a-b1a9-4a528ab667b2" />

Motivation

Describe how you validated your changes

<!--
Validate your changes before merge, ensuring that:

  • Your PR is tested by static / unit / integrations / e2e tests
  • Your PR description details which e2e tests cover your changes, if any
  • The PR description contains details of how you validated your changes. If you validated changes manually and not through automated tests, add context on why automated tests did not fit your changes validation.

If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.

Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->

  • added e2e tests around status display in the datadog-agent configurations
  • tested locally

Possible Drawbacks / Trade-offs

Additional Notes

<!--

  • Anything else we should know when reviewing?
  • Include benchmarking information here whenever possible.
  • Include info about alternatives that were considered and why the proposed
    version was chosen.
    -->

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner January 30, 2025 18:46
@agent-platform-auto-pr agent-platform-auto-pr bot added qa/done QA done before merge and regressions are covered by tests backport bot medium review PR review might take time labels Jan 30, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=54498143 --os-family=ubuntu

Note: This applies to commit bcd0afa

@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 1ac94d9c035cf3fddaa727935d2d6e2a6a847fcd

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 2.87MB 929.37MB 926.50MB 0.50MB
datadog-agent-arm64-deb 2.87MB 919.65MB 916.78MB 0.50MB
datadog-agent-x86_64-rpm 2.41MB 941.73MB 939.31MB 0.50MB
datadog-agent-x86_64-suse 2.41MB 941.73MB 939.31MB 0.50MB
datadog-agent-amd64-deb 2.41MB 931.99MB 929.57MB 0.50MB
datadog-heroku-agent-amd64-deb 2.35MB 480.24MB 477.89MB 0.50MB
datadog-dogstatsd-amd64-deb 0.02MB ⚠️ 58.89MB 58.88MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.02MB ⚠️ 58.97MB 58.95MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.02MB ⚠️ 58.97MB 58.95MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 56.40MB 56.39MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 93.97MB 93.97MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 90.02MB 90.02MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.09MB 90.09MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 94.04MB 94.04MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 94.04MB 94.04MB 0.50MB

Decision

❌ Failed

Currently this PR is blocked, you can reach out to #agent-delivery-help to get support/ask for an exception.

Copy link

cit-pr-commenter bot commented Jan 30, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 30966e92-5d49-4962-914f-2f5d9233eb32

Baseline: c4c9bb7
Comparison: bcd0afa
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.55 [+1.65, +3.44] 1 Logs
quality_gate_logs % cpu utilization +1.18 [-1.93, +4.29] 1 Logs
quality_gate_idle memory utilization +0.87 [+0.83, +0.91] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.63 [+0.56, +0.70] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.10 [-0.68, +0.88] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.05 [-0.41, +0.52] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.65] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.28, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.03] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.88, +0.86] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.80, +0.78] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.93, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.91, +0.78] 1 Logs
quality_gate_idle_all_features memory utilization -0.07 [-0.11, -0.02] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput -0.12 [-0.85, +0.61] 1 Logs
file_tree memory utilization -0.36 [-0.42, -0.30] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bot changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant