omnibus: add a way to force the generation of an installable package #33654
Conversation
chouquette
added
changelog/no-changelog
qa/no-code-change
github-actions
bot
added
the
short review
| @@ -110,6 +110,9 @@ | |||
| skip_healthcheck true | |||
| else | |||
| do_build = true | |||
| if ENV["OMNIBUS_FORCE_PACKAGES"] | |||
| do_package = true | |||
| end | |||
There was a problem hiding this comment.
Do we need to whitelist this variable somewhere in the python task?
There was a problem hiding this comment.
That depends on which list you're thinking about.
We could ignore it for the omnibus cache key generation (but since it's meant for local builds only I don't think we really care)
We might need to ensure it's forwarded to the omnibus env, but during my testing this was not required (but I thought it would, so I'll take a closer look)
If you were thinking about another list, let's discuss it :)
There was a problem hiding this comment.
We might need to ensure it's forwarded to the omnibus env, but during my testing this was not required (but I thought it would, so I'll take a closer look)
I was thinking about this one
There was a problem hiding this comment.
Oh well, I thought the environment we use in the omnibus build tasks was fully provided by the env parameter, but I was wrong.
Whatever we provide to omnibus_run_task (or to invoke.runner.Run for that matter) as the env parameter will modify the current process environment.
Put another way I thought we were using {}.update(env) but we're using os.environ.update(env)
There was a problem hiding this comment.
I'll add the variable to the explicitely forwarded environment in case this behavior changes when we fully switch to deva, of we find a way to enforce a cleaner env though invoke
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 0b256fc Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.07 | [+0.99, +1.14] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.13 | [-0.76, +1.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.08 | [-0.85, +1.01] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.03 | [-0.03, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.62, +0.65] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.01 | [-0.45, +0.48] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.29, +0.30] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.73, +0.74] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.02 | [-0.92, +0.87] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.06, +0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.07 | [-0.84, +0.71] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.39 | [-0.45, -0.32] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.63 | [-1.42, +0.16] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.83 | [-3.85, +2.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.54 | [-2.43, -0.65] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
github-actions
bot
added
medium review
chouquette
force-pushed
the
chouquette/update_build_doc
branch
from
d0ac435 to
eea8652
Compare
|
[Fast Unit Tests Report] On pipeline 56528660 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
chouquette
force-pushed
the
chouquette/update_build_doc
branch
from
eea8652 to
480206c
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
chouquette
force-pushed
the
chouquette/update_build_doc
branch
from
480206c to
5adcab1
Compare
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
Co-authored-by: Célian Raimbault <[email protected]>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The median merge time in
|
What does this PR do?
Update the local build doc & add a environment variable to force the generation of deb/rpm packages
Motivation
Simplify local building
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes