(fleet) change the install script to avoid the base64 embed #34146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbll
added
changelog/no-changelog
qa/done
github-actions
bot
added
long review
Gitlab CI Configuration ChangesModified Jobs.package_oci .package_oci:
artifacts:
paths:
- ${OMNIBUS_PACKAGE_DIR}
before_script:
- PACKAGE_VERSION="$(inv agent.version --url-safe)-1" || exit $?
- export INSTALL_DIR=/opt/datadog-packages/${OCI_PRODUCT}/${PACKAGE_VERSION}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache_tools.tar.xz
- rm -f $OMNIBUS_PACKAGE_DIR/*-dbg-*.tar.xz
- ls -l $OMNIBUS_PACKAGE_DIR
- python3 -m pip install -r tasks/libs/requirements-github.txt --break-system-packages
- set +x
- git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf
"https://github.com/DataDog/"
- go env -w GOPRIVATE="github.com/DataDog/*"
- ${CI_PROJECT_DIR}/tools/ci/retry.sh go install github.com/DataDog/datadog-packages/cmd/datadog-package@latest
- OUTPUT_DIR="/tmp/oci_output"
- mkdir -p ${OUTPUT_DIR}
- ls $OMNIBUS_PACKAGE_DIR
- "if [ $(ls $OMNIBUS_PACKAGE_DIR/*.oci.tar 2> /dev/null | wc -l) -ge 1 ]; then\n\
\ echo \"Copying already built images to output dir\"\n cp $OMNIBUS_PACKAGE_DIR/*.oci.tar\
\ ${OUTPUT_DIR}\nfi\n"
- "for ARCH in \"amd64\" \"arm64\"; do\n INPUT_FILE=\"${OMNIBUS_PACKAGE_DIR}${OCI_PRODUCT}-*${ARCH}.tar.xz\"\
\n OUTPUT_FILE=\"$(basename -a -s .xz ${INPUT_FILE})\"\n MERGED_FILE=$(basename\
\ -a $OMNIBUS_PACKAGE_DIR/*.tar.xz | head -n 1 | sed \"s/-${ARCH}.tar.xz//\").oci.tar\n\
\ export MERGED_FILE\n INPUT_DIR=\"/tmp/input_${ARCH}\"\n mkdir -p ${INPUT_DIR}\n\
\ echo \"Generating OCI for $ARCH.\"\n echo \"Extracting to temporary input\
\ dir $INPUT_FILE -> $INPUT_DIR\"\n tar xJf ${INPUT_FILE} -C ${INPUT_DIR}\n \
\ echo \"Creating OCI layer -> ${OUTPUT_DIR}/${OUTPUT_FILE}\"\n if [ \"${OCI_PRODUCT}\"\
\ = \"datadog-agent\" ]; then\n EXTRA_FLAGS=\"--configs ${INPUT_DIR}/etc/datadog-agent\"\
- \n fi\n datadog-package create \\\n --version ${PACKAGE_VERSION} \\\n \
+ \n fi\n if [ \"${OCI_PRODUCT}\" = \"datadog-installer\" ]; then\n EXTRA_FLAGS=\"\
+ --installer ${INPUT_DIR}/${INSTALL_DIR}/bin/installer/installer\"\n fi\n datadog-package\
+ \ create \\\n --version ${PACKAGE_VERSION} \\\n --package ${OCI_PRODUCT}\
- \ --package ${OCI_PRODUCT} \\\n --os linux \\\n --arch ${ARCH} \\\n --archive\
? -------------------------
+ \ \\\n --os linux \\\n --arch ${ARCH} \\\n --archive --archive-path \"\
? ++++++++++++++++ ++
- \ --archive-path \"${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n\
- \ ${INPUT_DIR}/${INSTALL_DIR}/\n rm -f ${INPUT_FILE}\ndone\n"
+ ${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n ${INPUT_DIR}/${INSTALL_DIR}/\n\
+ \ rm -f ${INPUT_FILE}\ndone\n"
- echo "Aggregating all layers into one package -> ${MERGED_FILE}"
- ls -l ${OUTPUT_DIR}/
- datadog-package merge ${OUTPUT_DIR}/*.tar
- mv merged.tar ${OMNIBUS_PACKAGE_DIR}/${MERGED_FILE}
stage: packaging
tags:
- arch:amd64
variables:
KUBERNETES_CPU_REQUEST: 16
KUBERNETES_MEMORY_LIMIT: 32Gi
KUBERNETES_MEMORY_REQUEST: 32Giagent_oci agent_oci:
artifacts:
paths:
- ${OMNIBUS_PACKAGE_DIR}
before_script:
- PACKAGE_VERSION="$(inv agent.version --url-safe)-1" || exit $?
- export INSTALL_DIR=/opt/datadog-packages/${OCI_PRODUCT}/${PACKAGE_VERSION}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- datadog-agent-oci-x64-a7
- datadog-agent-oci-arm64-a7
- windows_msi_and_bosh_zip_x64-a7
- go_tools_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache_tools.tar.xz
- rm -f $OMNIBUS_PACKAGE_DIR/*-dbg-*.tar.xz
- ls -l $OMNIBUS_PACKAGE_DIR
- python3 -m pip install -r tasks/libs/requirements-github.txt --break-system-packages
- set +x
- git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf
"https://github.com/DataDog/"
- go env -w GOPRIVATE="github.com/DataDog/*"
- ${CI_PROJECT_DIR}/tools/ci/retry.sh go install github.com/DataDog/datadog-packages/cmd/datadog-package@latest
- OUTPUT_DIR="/tmp/oci_output"
- mkdir -p ${OUTPUT_DIR}
- ls $OMNIBUS_PACKAGE_DIR
- "if [ $(ls $OMNIBUS_PACKAGE_DIR/*.oci.tar 2> /dev/null | wc -l) -ge 1 ]; then\n\
\ echo \"Copying already built images to output dir\"\n cp $OMNIBUS_PACKAGE_DIR/*.oci.tar\
\ ${OUTPUT_DIR}\nfi\n"
- "for ARCH in \"amd64\" \"arm64\"; do\n INPUT_FILE=\"${OMNIBUS_PACKAGE_DIR}${OCI_PRODUCT}-*${ARCH}.tar.xz\"\
\n OUTPUT_FILE=\"$(basename -a -s .xz ${INPUT_FILE})\"\n MERGED_FILE=$(basename\
\ -a $OMNIBUS_PACKAGE_DIR/*.tar.xz | head -n 1 | sed \"s/-${ARCH}.tar.xz//\").oci.tar\n\
\ export MERGED_FILE\n INPUT_DIR=\"/tmp/input_${ARCH}\"\n mkdir -p ${INPUT_DIR}\n\
\ echo \"Generating OCI for $ARCH.\"\n echo \"Extracting to temporary input\
\ dir $INPUT_FILE -> $INPUT_DIR\"\n tar xJf ${INPUT_FILE} -C ${INPUT_DIR}\n \
\ echo \"Creating OCI layer -> ${OUTPUT_DIR}/${OUTPUT_FILE}\"\n if [ \"${OCI_PRODUCT}\"\
\ = \"datadog-agent\" ]; then\n EXTRA_FLAGS=\"--configs ${INPUT_DIR}/etc/datadog-agent\"\
- \n fi\n datadog-package create \\\n --version ${PACKAGE_VERSION} \\\n \
+ \n fi\n if [ \"${OCI_PRODUCT}\" = \"datadog-installer\" ]; then\n EXTRA_FLAGS=\"\
+ --installer ${INPUT_DIR}/${INSTALL_DIR}/bin/installer/installer\"\n fi\n datadog-package\
+ \ create \\\n --version ${PACKAGE_VERSION} \\\n --package ${OCI_PRODUCT}\
- \ --package ${OCI_PRODUCT} \\\n --os linux \\\n --arch ${ARCH} \\\n --archive\
? -------------------------
+ \ \\\n --os linux \\\n --arch ${ARCH} \\\n --archive --archive-path \"\
? ++++++++++++++++ ++
- \ --archive-path \"${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n\
- \ ${INPUT_DIR}/${INSTALL_DIR}/\n rm -f ${INPUT_FILE}\ndone\n"
+ ${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n ${INPUT_DIR}/${INSTALL_DIR}/\n\
+ \ rm -f ${INPUT_FILE}\ndone\n"
- echo "Aggregating all layers into one package -> ${MERGED_FILE}"
- ls -l ${OUTPUT_DIR}/
- datadog-package merge ${OUTPUT_DIR}/*.tar
- mv merged.tar ${OMNIBUS_PACKAGE_DIR}/${MERGED_FILE}
stage: packaging
tags:
- arch:amd64
variables:
KUBERNETES_CPU_REQUEST: 16
KUBERNETES_MEMORY_LIMIT: 32Gi
KUBERNETES_MEMORY_REQUEST: 32Gi
OCI_PRODUCT: datadog-agentinstaller-install-scripts installer-install-scripts:
artifacts:
expire_in: 2 weeks
paths:
- $OMNIBUS_PACKAGE_DIR
image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- go_mod_tidy_check
- go_deps
+ - installer-amd64-oci
+ - installer-arm64-oci
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache.tar.xz
- VERSION="$(inv agent.version --url-safe)-1" || exit $?
- echo "About to build for $VERSION"
- mkdir -p $OMNIBUS_PACKAGE_DIR
+ - tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*amd64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
+ > installer-amd64
+ - tar -xJOf $OMNIBUS_PACKAGE_DIR/datadog-installer-7*arm64.tar.xz --wildcards "opt/datadog-packages/datadog-installer/*/bin/installer/installer"
+ > installer-arm64
- - inv -e installer.build-linux-script "default" "$VERSION"
+ - inv -e installer.build-linux-script "default" "$VERSION" "installer-amd64" "installer-arm64"
? ++++++++++++++++++++++++++++++++++++
+ "install.sh"
- - inv -e installer.build-linux-script "databricks" "$VERSION"
+ - inv -e installer.build-linux-script "databricks" "$VERSION" "installer-amd64"
? ++++++++++++++++++
+ "installer-arm64" "install-databricks.sh"
- - inv -e installer.build-linux-script "emr" "$VERSION"
+ - inv -e installer.build-linux-script "emr" "$VERSION" "installer-amd64" "installer-arm64"
? ++++++++++++++++++++++++++++++++++++
+ "install-emr.sh"
- - inv -e installer.build-linux-script "dataproc" "$VERSION"
+ - inv -e installer.build-linux-script "dataproc" "$VERSION" "installer-amd64" "installer-arm64"
? ++++++++++++++++++++++++++++++++++++
+ "install-dataproc.sh"
- mv ./bin/installer/install*.sh $OMNIBUS_PACKAGE_DIR/
- ls -la $OMNIBUS_PACKAGE_DIR
stage: package_build
tags:
- arch:amd64
variables:
KUBERNETES_CPU_REQUEST: 8
KUBERNETES_MEMORY_LIMIT: 16Gi
KUBERNETES_MEMORY_REQUEST: 16Gi
RELEASE_VERSION: $RELEASE_VERSION_7installer_oci installer_oci:
artifacts:
paths:
- ${OMNIBUS_PACKAGE_DIR}
before_script:
- PACKAGE_VERSION="$(inv agent.version --url-safe)-1" || exit $?
- export INSTALL_DIR=/opt/datadog-packages/${OCI_PRODUCT}/${PACKAGE_VERSION}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
needs:
- installer-arm64-oci
- installer-amd64-oci
- windows-installer-amd64
- go_tools_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache_tools.tar.xz -C $GOPATH/pkg/mod/cache
|| exit 101
- rm -f modcache_tools.tar.xz
- rm -f $OMNIBUS_PACKAGE_DIR/*-dbg-*.tar.xz
- ls -l $OMNIBUS_PACKAGE_DIR
- python3 -m pip install -r tasks/libs/requirements-github.txt --break-system-packages
- set +x
- git config --global url."https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/".insteadOf
"https://github.com/DataDog/"
- go env -w GOPRIVATE="github.com/DataDog/*"
- ${CI_PROJECT_DIR}/tools/ci/retry.sh go install github.com/DataDog/datadog-packages/cmd/datadog-package@latest
- OUTPUT_DIR="/tmp/oci_output"
- mkdir -p ${OUTPUT_DIR}
- ls $OMNIBUS_PACKAGE_DIR
- "if [ $(ls $OMNIBUS_PACKAGE_DIR/*.oci.tar 2> /dev/null | wc -l) -ge 1 ]; then\n\
\ echo \"Copying already built images to output dir\"\n cp $OMNIBUS_PACKAGE_DIR/*.oci.tar\
\ ${OUTPUT_DIR}\nfi\n"
- "for ARCH in \"amd64\" \"arm64\"; do\n INPUT_FILE=\"${OMNIBUS_PACKAGE_DIR}${OCI_PRODUCT}-*${ARCH}.tar.xz\"\
\n OUTPUT_FILE=\"$(basename -a -s .xz ${INPUT_FILE})\"\n MERGED_FILE=$(basename\
\ -a $OMNIBUS_PACKAGE_DIR/*.tar.xz | head -n 1 | sed \"s/-${ARCH}.tar.xz//\").oci.tar\n\
\ export MERGED_FILE\n INPUT_DIR=\"/tmp/input_${ARCH}\"\n mkdir -p ${INPUT_DIR}\n\
\ echo \"Generating OCI for $ARCH.\"\n echo \"Extracting to temporary input\
\ dir $INPUT_FILE -> $INPUT_DIR\"\n tar xJf ${INPUT_FILE} -C ${INPUT_DIR}\n \
\ echo \"Creating OCI layer -> ${OUTPUT_DIR}/${OUTPUT_FILE}\"\n if [ \"${OCI_PRODUCT}\"\
\ = \"datadog-agent\" ]; then\n EXTRA_FLAGS=\"--configs ${INPUT_DIR}/etc/datadog-agent\"\
- \n fi\n datadog-package create \\\n --version ${PACKAGE_VERSION} \\\n \
+ \n fi\n if [ \"${OCI_PRODUCT}\" = \"datadog-installer\" ]; then\n EXTRA_FLAGS=\"\
+ --installer ${INPUT_DIR}/${INSTALL_DIR}/bin/installer/installer\"\n fi\n datadog-package\
+ \ create \\\n --version ${PACKAGE_VERSION} \\\n --package ${OCI_PRODUCT}\
- \ --package ${OCI_PRODUCT} \\\n --os linux \\\n --arch ${ARCH} \\\n --archive\
? -------------------------
+ \ \\\n --os linux \\\n --arch ${ARCH} \\\n --archive --archive-path \"\
? ++++++++++++++++ ++
- \ --archive-path \"${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n\
- \ ${INPUT_DIR}/${INSTALL_DIR}/\n rm -f ${INPUT_FILE}\ndone\n"
+ ${OUTPUT_DIR}/${OUTPUT_FILE}\" \\\n ${EXTRA_FLAGS} \\\n ${INPUT_DIR}/${INSTALL_DIR}/\n\
+ \ rm -f ${INPUT_FILE}\ndone\n"
- echo "Aggregating all layers into one package -> ${MERGED_FILE}"
- ls -l ${OUTPUT_DIR}/
- datadog-package merge ${OUTPUT_DIR}/*.tar
- mv merged.tar ${OMNIBUS_PACKAGE_DIR}/${MERGED_FILE}
stage: packaging
tags:
- arch:amd64
variables:
KUBERNETES_CPU_REQUEST: 16
KUBERNETES_MEMORY_LIMIT: 32Gi
KUBERNETES_MEMORY_REQUEST: 32Gi
OCI_PRODUCT: datadog-installerChanges Summary
ℹ️ Diff available in the job log. |
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 42bd266 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +4.49 | [+1.36, +7.62] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.57 | [-0.35, +1.50] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.40 | [+0.37, +0.44] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.11 | [-0.35, +0.57] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.08 | [-0.84, +1.00] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.07 | [-0.72, +0.86] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.65] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.94, +0.96] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.29, +0.31] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.93, +0.95] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.73, +0.70] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.07 | [-0.12, -0.01] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.44 | [-1.22, +0.34] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.67 | [-0.73, -0.62] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -2.05 | [-2.12, -1.99] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
github-actions
bot
added
medium review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=56443515 --os-family=ubuntuNote: This applies to commit 0334afb |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
raphaelgavache
approved these changes
Feb 20, 2025
BaptisteFoy
approved these changes
Feb 20, 2025
chouquette
approved these changes
Feb 20, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The median merge time in
|
Static quality checks ❌Please find below the results from static quality gates Error
Gate failure full details
Successful checksInfo
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR simplifies the fleet install script by avoiding the golang base64 embedded binary used to download the installer. The tradeoff is we have to rely on:
sha256sumcurlorwgetThis should be acceptable given that
sha256sumis incoreutilssince 2008 and all non-minimal distributions ship with eithercurlorwget.Motivation
While the base64 embed works, we've discovered with usage it has a few limitations we want to get rid of (long startup time,
curl | bashhanging)Describe how you validated your changes