(fleet) Change installer directories permissions on Windows

[bmermet]

What does this PR do?

This PR makes the folders where packages are installed world readable. This is consistent with what is done for linux and is required for single step instrumentation to reference libraries installed by the installer.

The top level directory keeps its traversal only permissions, that way the files in the temporary directories created by the installer remain private to the installer user like on linux.

Motivation

Enable SSI for dotnet.

Describe how you validated your changes

This was validated manually + with system tests.

Possible Drawbacks / Trade-offs

Additional Notes

https://datadoghq.atlassian.net/browse/INPLAT-432

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 52aba8ab-822f-4748-b777-26e463490d2f

Baseline: f23a366
Comparison: 679e1ce
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.78	[+0.85, +2.72]	1	Logs
➖	quality_gate_logs	% cpu utilization	+1.07	[-1.88, +4.03]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.80	[+0.74, +0.85]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.34	[-0.12, +0.81]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.28	[-0.50, +1.05]	1	Logs
➖	file_tree	memory utilization	+0.10	[+0.03, +0.16]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.62, +0.66]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.28, +0.31]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.81, +0.82]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.00	[-0.85, +0.85]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.00	[-0.78, +0.77]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.00	[-0.77, +0.76]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.02	[-0.66, +0.61]	1	Logs
➖	quality_gate_idle	memory utilization	-0.09	[-0.13, -0.06]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.88	[-1.94, -1.81]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57038890 --os-family=ubuntu

Note: This applies to commit 679e1ce

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor f23a366fa66b11505843abf4f074352f52808c12

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-arm64-deb	0.01MB	⚠️	808.85MB	808.84MB	0.50MB
datadog-agent-aarch64-rpm	0.01MB	⚠️	818.62MB	818.62MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	827.66MB	827.66MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	827.66MB	827.66MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	817.87MB	817.87MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	39.42MB	39.42MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	39.50MB	39.50MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	37.96MB	37.96MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.28MB	443.28MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.02MB	62.02MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.09MB	62.09MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.27MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.33MB	59.33MB	0.50MB

Decision

⚠️ Warning

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	791.75MiB	817.79MiB	192.64MiB	204.92MiB
✅	static_quality_gate_agent_deb_arm64	783.02MiB	808.76MiB	175.58MiB	186.5MiB
✅	static_quality_gate_agent_rpm_amd64	791.77MiB	817.82MiB	195.05MiB	208.12MiB
✅	static_quality_gate_agent_rpm_arm64	783.01MiB	808.76MiB	176.43MiB	188.34MiB
✅	static_quality_gate_agent_suse_amd64	791.8MiB	817.82MiB	195.05MiB	208.12MiB
✅	static_quality_gate_agent_suse_arm64	783.16MiB	808.86MiB	176.43MiB	188.33MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.7MiB	9.78MiB	19.8MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	46.3MiB	8.48MiB	18.5MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.7MiB	9.79MiB	19.8MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.7MiB	9.79MiB	19.8MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.83MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.13MiB	902.2MiB	294.21MiB	308.43MiB
✅	static_quality_gate_docker_agent_arm64	890.79MiB	916.47MiB	280.47MiB	294.23MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.07GiB	369.33MiB	383.54MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.08GiB	351.58MiB	365.31MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	55.78MiB	17.28MiB	27.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.47MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.94MiB	274.78MiB	106.35MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.9MiB	290.82MiB	101.19MiB	111.12MiB

[agent-platform-auto-pr]

Static quality checks ❌

Please find below the results from static quality gates

Error

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
❌	static_quality_gate_agent_suse_amd64	DataNotFound	817.82MiB	DataNotFound	208.12MiB

Gate failure full details

Quality gate	Error type	Error message
static_quality_gate_agent_suse_amd64	StackTrace	Traceback (most recent call last): File "/go/src/github.com/DataDog/datadog-agent/tasks/quality_gates.py", line 121, in parse_and_trigger_gates gate_mod.entrypoint(**gate_inputs) File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/static_quality_gate_agent_suse_amd64.py", line 5, in entrypoint generic_package_agent_quality_gate( File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 69, in generic_package_agent_quality_gate package_on_wire_size, package_on_disk_size = calculate_package_size( ^^^^^^^^^^^^^^^^^^^^^^^ File "/go/src/github.com/DataDog/datadog-agent/tasks/static_quality_gates/lib/package_agent_lib.py", line 10, in calculate_package_size extract_package(ctx=ctx, package_os=package_os, package_path=package_path, extract_dir=extract_dir) File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 72, in extract_package return extract_rpm_package(ctx, package_path, extract_dir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/go/src/github.com/DataDog/datadog-agent/tasks/libs/package/size.py", line 65, in extract_rpm_package ctx.run(f"rpm2cpio {package_path}

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	791.87MiB	817.79MiB	192.63MiB	204.92MiB
✅	static_quality_gate_agent_deb_arm64	783.23MiB	808.76MiB	174.18MiB	186.5MiB
✅	static_quality_gate_agent_rpm_amd64	791.86MiB	817.82MiB	195.08MiB	208.12MiB
✅	static_quality_gate_agent_rpm_arm64	783.17MiB	808.76MiB	176.39MiB	188.34MiB
✅	static_quality_gate_agent_suse_arm64	783.22MiB	808.86MiB	176.39MiB	188.33MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	47.7MiB	9.78MiB	19.8MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.27MiB	46.3MiB	8.48MiB	18.5MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	47.7MiB	9.79MiB	19.8MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	47.7MiB	9.79MiB	19.8MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.82MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.6MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	876.12MiB	902.2MiB	294.2MiB	308.43MiB
✅	static_quality_gate_docker_agent_arm64	890.78MiB	916.47MiB	280.47MiB	294.23MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.05GiB	1.07GiB	369.32MiB	383.54MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.05GiB	1.08GiB	351.56MiB	365.31MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.81MiB	55.78MiB	17.28MiB	27.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	54.47MiB	16.16MiB	26.16MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.94MiB	274.78MiB	106.35MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.9MiB	290.82MiB	101.19MiB	111.12MiB