Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete experimental code #34299

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove obsolete experimental code #34299

wants to merge 1 commit into from

Conversation

vickenty
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-metric-pipelines short review PR is simple enough to be reviewed quickly labels Feb 21, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56548793 --os-family=ubuntu

Note: This applies to commit b938203

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 92c2e3bd9dcb932119f28f08d072ae4b517bddbc

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 869.07MB 869.07MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 878.83MB 878.83MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 878.83MB 878.83MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.40MB 41.40MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.48MB 41.48MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.48MB 41.48MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.26MB 59.26MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB
datadog-agent-arm64-deb -0.00MB 858.38MB 858.38MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 868.12MB 868.13MB 0.50MB
datadog-dogstatsd-arm64-deb -0.00MB 39.66MB 39.66MB 0.50MB
datadog-heroku-agent-amd64-deb -0.00MB 446.32MB 446.32MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 840.69MiB 847.49MiB 202.98MiB 212.33MiB
static_quality_gate_agent_deb_arm64 830.44MiB 836.66MiB 182.14MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 840.61MiB 847.82MiB 206.03MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 830.47MiB 836.66MiB 185.32MiB 194.24MiB
static_quality_gate_agent_suse_amd64 840.52MiB 847.82MiB 206.03MiB 215.76MiB
static_quality_gate_agent_suse_arm64 830.32MiB 836.66MiB 185.32MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.56MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.9MiB 48.1MiB 9.13MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.22MiB 69.0MiB 14.88MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.83MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 924.93MiB 931.7MiB 309.07MiB 318.67MiB
static_quality_gate_docker_agent_arm64 938.0MiB 944.08MiB 294.06MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.1GiB 384.18MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.1GiB 365.14MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.7MiB 57.88MiB 18.26MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.09MiB 56.27MiB 17.02MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.33MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.2MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9e8e22ff-23c8-4091-8ad3-bdfba357ebaf

Baseline: 92c2e3b
Comparison: b938203
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.28 [-0.79, +5.34] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.83 [-0.05, +1.71] 1 Logs
file_tree memory utilization +0.18 [+0.12, +0.24] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.08 [+0.01, +0.15] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.75, +0.82] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.75, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.80, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.65, +0.66] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.76, +0.76] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.31, +0.29] 1 Logs
quality_gate_idle memory utilization -0.05 [-0.08, -0.02] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.14 [-0.61, +0.33] 1 Logs
quality_gate_idle_all_features memory utilization -0.16 [-0.21, -0.11] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.39 [-1.16, +0.38] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/agent-metric-pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant