Don't duplicate agent builds for OTEL collector #34304
Open
+224
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouquette
added
changelog/no-changelog
qa/no-code-change
|
Continuation from #33962 |
|
[Fast Unit Tests Report] On pipeline 57002489 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 3 | 15 | 3 | 0 |
ℹ️ Diff available in the job log.
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 224808e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.28 | [-0.18, +0.74] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.25 | [-0.53, +1.04] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.16 | [+0.10, +0.23] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.16 | [+0.10, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.02] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.00 | [-0.80, +0.79] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.01 | [-0.81, +0.79] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.30, +0.28] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.64, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.74, +0.70] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.82, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.85, +0.79] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.27 | [-0.33, -0.21] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.62 | [-3.53, +2.28] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.63 | [-0.68, -0.58] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.28 | [-3.14, -1.43] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
chouquette
force-pushed
the
chouquette/refactor_otel_builds
branch
from
0c73718 to
c65f4ec
Compare
CelianR
approved these changes
Feb 24, 2025
this will simplify merging them with the agent ones
Co-authored-by: Célian Raimbault <[email protected]>
chouquette
force-pushed
the
chouquette/refactor_otel_builds
branch
from
ab02d79 to
1f76ca0
Compare
Comment on lines
+196
to
+210
| datadog-otel-agent-x64: | ||
| extends: .otel_build_common | ||
| image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-17-x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES | ||
| tags: ["arch:amd64"] | ||
| variables: | ||
| DD_CC: "x86_64-unknown-linux-gnu-gcc" | ||
| DD_CXX: "x86_64-unknown-linux-gnu-g++" | ||
|
|
||
| datadog-otel-agent-arm64: | ||
| extends: .otel_build_common | ||
| image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux-glibc-2-23-arm64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES | ||
| tags: ["arch:arm64"] | ||
| variables: | ||
| DD_CC: "aarch64-unknown-linux-gnu-gcc" | ||
| DD_CXX: "aarch64-unknown-linux-gnu-g++" |
There was a problem hiding this comment.
Nit - we could have a matrix to avoid some cpy/paste
There was a problem hiding this comment.
Given that we have 3 values to modify (the image name, the tag, a the compiler prefix) for a 7 lines job, I'm not sure a matrix would improve the readability/maintainability here
| Omnibus::Config.git_cache_dir ENV["OMNIBUS_GIT_CACHE_DIR"] | ||
| end | ||
|
|
||
| if windows_target? || osx_target? |
There was a problem hiding this comment.
nit - I'd have used unless linux_target
There was a problem hiding this comment.
makes sense, updated
| # ------------------------------------ | ||
| dependency 'datadog-otel-agent' | ||
|
|
||
| if linux_target? |
There was a problem hiding this comment.
We keep the if statement to be future proof for when we'll add windows?
| additional_versions = FFI_Yajl::Parser.parse(File.read(version_manifest_json_path)) | ||
|
|
||
| versions["software"].merge!(additional_versions["software"]) | ||
| delete version_manifest_json_path |
There was a problem hiding this comment.
I don't remember why exactly, but I think FileUtils.rm is preferred over delete in a block
There was a problem hiding this comment.
You're right, something to do with dsl commands being queued up, also I thought it didn't occur in a block, but that's a bit blurry.
Changed to FileUtils.rm so that we don't have to wonder
There was a problem hiding this comment.
Florent is right, using delete in a block will mess up the order of execution in potentially unexpected ways. I see a command and a delete further down inside a block too.
On a tangential note, block's accept an argument such that you can give them a descriptive name over what they're supposed to achieve, like in this example. In case you find it appropriate for these blocks, too.
There was a problem hiding this comment.
blocks are now named and shellout! is used instead of command
github-actions
bot
added
long review
FlorentClarret
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Builds the OTEL enabled agent from the regular agent builds & a dedicated
otel-agentbuildMotivation
Cut the build durations in half, and restore the ability to profile our agent, regardless of OTEL status, since the
BuildIDfor all binaries will be consistent with the debug symbols we ship.Describe how you validated your changes
Manual verification of the
version-manifest.{json,txt}filesPossible Drawbacks / Trade-offs
Additional Notes