Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs and epforwarders to support API key refresh #34351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hush-hush
Copy link
Member

What does this PR do?

This enabled support for API key refresh for epforwarder.

This also includes support for 'additional_endpoints' (ie: Dual Shipping)

Describe how you validated your changes

WIP: We still need to add unit tests

@hush-hush hush-hush requested review from a team as code owners February 24, 2025 11:29
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Feb 24, 2025
Copy link

cit-pr-commenter bot commented Feb 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 25be7813-afe6-4747-8645-c1ac56bf2f66

Baseline: 153cd14
Comparison: ebc4b8e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.68 [+0.62, +0.74] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.31 [-0.48, +1.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.28 [-0.50, +1.06] 1 Logs
quality_gate_idle_all_features memory utilization +0.22 [+0.16, +0.27] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.09 [-0.37, +0.56] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.78, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.27, +0.31] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.83, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.68, +0.69] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.84, +0.81] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.64, +0.61] 1 Logs
quality_gate_idle memory utilization -0.36 [-0.40, -0.32] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.81 [-0.87, -0.76] 1 Logs
quality_gate_logs % cpu utilization -0.82 [-3.71, +2.06] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.15 [-2.01, -0.29] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@hush-hush hush-hush force-pushed the maxime/update-epforwarder-api-key-refresh branch 2 times, most recently from 425f3b0 to dc7644a Compare February 24, 2025 13:51
@hush-hush hush-hush added the qa/rc-required Only for a PR that requires validation on the Release Candidate label Feb 24, 2025
@hush-hush hush-hush force-pushed the maxime/update-epforwarder-api-key-refresh branch 2 times, most recently from ec14f42 to c65b47a Compare February 24, 2025 14:22
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=57034908 --os-family=ubuntu

Note: This applies to commit ebc4b8e

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Uncompressed package size comparison

Comparison with ancestor 153cd143979ee9acb303aa22608e636442089005

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.06MB ⚠️ 845.61MB 845.55MB 0.50MB
datadog-agent-x86_64-suse 0.06MB ⚠️ 845.61MB 845.55MB 0.50MB
datadog-agent-amd64-deb 0.06MB ⚠️ 835.82MB 835.76MB 0.50MB
datadog-agent-arm64-deb 0.05MB ⚠️ 826.33MB 826.28MB 0.50MB
datadog-agent-aarch64-rpm 0.05MB ⚠️ 836.10MB 836.05MB 0.50MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 443.29MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 62.04MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 62.11MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 62.11MB 62.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.01MB ⚠️ 37.97MB 37.96MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 59.34MB 59.33MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 24, 2025

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 808.89MiB 841.59MiB 195.26MiB 210.72MiB
static_quality_gate_agent_deb_arm64 799.73MiB 830.66MiB 177.1MiB 192.1MiB
static_quality_gate_agent_rpm_amd64 808.9MiB 841.52MiB 198.16MiB 214.52MiB
static_quality_gate_agent_rpm_arm64 799.66MiB 830.66MiB 178.84MiB 193.64MiB
static_quality_gate_agent_suse_amd64 808.75MiB 841.52MiB 198.16MiB 214.52MiB
static_quality_gate_agent_suse_arm64 799.79MiB 830.66MiB 178.84MiB 194.03MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 49.7MiB 9.78MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 36.28MiB 48.1MiB 8.49MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 49.7MiB 9.79MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.24MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.6MiB 66.4MiB 12.82MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.24MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.24MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_docker_agent_amd64 893.25MiB 926.0MiB 298.82MiB 317.43MiB
static_quality_gate_docker_agent_arm64 907.46MiB 939.07MiB 284.54MiB 302.43MiB
static_quality_gate_docker_agent_jmx_amd64 1.07GiB 1.1GiB 373.94MiB 392.54MiB
static_quality_gate_docker_agent_jmx_arm64 1.07GiB 1.1GiB 355.64MiB 373.21MiB
static_quality_gate_docker_dogstatsd_amd64 45.82MiB 57.88MiB 17.28MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.46MiB 56.27MiB 16.16MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.35MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.19MiB 111.12MiB

This also includes support for 'additional_endpoints' (ie: Dual Shipping)
@hush-hush hush-hush force-pushed the maxime/update-epforwarder-api-key-refresh branch from c65b47a to ebc4b8e Compare February 26, 2025 12:08
@hush-hush hush-hush changed the title [WIP] Update logs and ep forwarders to support API key refresh Update logs and ep forwarders to support API key refresh Feb 26, 2025
@hush-hush hush-hush changed the title Update logs and ep forwarders to support API key refresh Update logs and epforwarders to support API key refresh Feb 26, 2025
Copy link
Contributor

@andrewqian2001datadog andrewqian2001datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hush-hush hush-hush requested a review from dustmop February 26, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/rc-required Only for a PR that requires validation on the Release Candidate team/agent-configuration team/database-monitoring team/ndm-core team/network-device-monitoring team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants