Skip to content

Run tests on a schedule and integrate with Datadog's test optimization product #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 44 commits into from

Conversation

michael-richey
Copy link
Collaborator

@michael-richey michael-richey commented Apr 17, 2025

What does this PR do?

Integrate with Datadog's test optimization product and run the tests more regularly.

Description of the Change

Configure the github actions.

- 8126:8126
steps:
- name: Configure Datadog Test Optimization
uses: datadog/test-visibility-github-action@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)

Pin GitHub Actions by commit hash to ensure supply chain security.

Using a branch (@main) or tag (@v1) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:

      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

View in Datadog  Leave us feedback  Documentation

@michael-richey michael-richey changed the title Try datadog test optimization Run tests on a schedule and integrate with Datadog's test optimization product May 7, 2025
@michael-richey michael-richey marked this pull request as ready for review May 7, 2025 17:13
@michael-richey michael-richey requested a review from a team as a code owner May 7, 2025 17:13
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025

Datadog Summary

✅ Code Quality    ❌ Code Security    ❌ Dependencies

Next Steps

Fix this code security issue introduced by this PR:

🔴 High: github-actions/unpinned-actions
.github/workflows/datadog_test_optimization.yml:45

Workflow depends on unpinned GitHub Actions



Fix these dependency issues introduced by this PR:

🔴 High: certifi 2022.12.7

Removal of e-Tugra root certificate

🔴 High: setuptools 67.6.0

setuptools vulnerable to Command Injection via package URL

🟠 Medium: aiohttp 3.9.5

In aiohttp, compressed files as symlinks are not protected from path traversal

and 2 more. View all

Was this helpful? Give us feedback!

deepdiff==6.7.1
aiohttp==3.9.5
tqdm==4.66.2
certifi>=2022.12.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 High: Library Vulnerability

certifi → 2022.12.7

Removal of e-Tugra root certificate

View in Datadog  Leave us feedback  Documentation

tqdm==4.66.2
certifi>=2022.12.7
python-dateutil
setuptools>=67.6.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 High: Library Vulnerability

setuptools → 67.6.0

setuptools vulnerable to Command Injection via package URL

View in Datadog  Leave us feedback  Documentation

click==8.1.7
configobj==5.0.8
deepdiff==6.7.1
aiohttp==3.9.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium: Library Vulnerability

aiohttp → 3.9.5

In aiohttp, compressed files as symlinks are not protected from path traversal

View in Datadog  Leave us feedback  Documentation

configobj==5.0.8
deepdiff==6.7.1
aiohttp==3.9.5
tqdm==4.66.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Low: Library Vulnerability

tqdm → 4.66.2

tqdm CLI arguments injection attack

View in Datadog  Leave us feedback  Documentation

@@ -0,0 +1,18 @@
boto3==1.35.91
click==8.1.7
configobj==5.0.8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Low: Library Vulnerability

configobj → 5.0.8

configobj ReDoS exploitable by developer using values in a server-side configuration file

View in Datadog  Leave us feedback  Documentation

- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- name: Configure Datadog Test Optimization
uses: datadog/test-visibility-github-action@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 High: Code Vulnerability

Workflow depends on a GitHub actions pinned by tag instead of a hash. (...read more)

Pin GitHub Actions by commit hash to ensure supply chain security.

Using a branch (@main) or tag (@v1) allows for implicit updates, which can introduce unexpected or malicious changes. Instead, always pin actions to a full length commit SHA. You can find the commit SHA for the latest tag from the action’s repository and ensure frequent updates via auto-updaters such as dependabot. Include a comment with the corresponding full-length SemVer tag for clarity:

      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

View in Datadog  Leave us feedback  Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant