Skip to content

Fix SLO update via dogshell #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aserrallerios
Copy link

@aserrallerios aserrallerios commented Feb 12, 2025

What does this PR do?

The SLO update is broken. The server side will always return this error no matter the inputs:

ERROR: Invalid payload: 'target' should be number

Also, during SLO updates, name argument is ignored.

This PR fixes both issues.

Description of the Change

We transform the thresholds target string to float, just like in the SLO creation. The DataDog API expects a number in the json body, not a string. We also add the name argument to the parameters of the request.

Alternate Designs

N/A

Possible Drawbacks

None. Probably this never worked and clients are not depending on it.

Verification Process

Empirically on my computer.

Additional Notes

N/A

Release Notes

Fix SLO update via dogshell. This fixes a bug in dogshell that always produced ERROR: Invalid payload: 'target' should be number error during SLO updates, and also takes into account the name argument.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@aserrallerios aserrallerios requested a review from a team as a code owner February 12, 2025 16:08
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale - Bot reminder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant