Set 722 file permissions on UDS socket #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
force-pushed
the
fix-uds
branch
2 times, most recently
from
0528fba to
895d265
Compare
devinsba
approved these changes
Aug 2, 2022
| apm_sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) | ||
| apm_sock.bind(parsed_args.trace_uds_socket) | ||
| os.chmod(parsed_args.trace_uds_socket, 0o777) | ||
| atexit.register(lambda: os.unlink(parsed_args.trace_uds_socket)) |
There was a problem hiding this comment.
This is cool, this is the part I was missing this morning
Kyle-Verhoog
changed the title
The permissions of the socket created by aiohttp aren't as permissive as the ones set by the real agent. (see aio-libs/aiohttp#4155) from @devinsba: test agent: ``` cnb@my-app:/var/run/datadog$ ls -la total 4 drwxr-xr-x 2 root root 60 Aug 1 21:24 . drwxr-xr-x 1 root root 4096 Aug 1 21:24 .. srwxr-xr-x 1 root root 0 Aug 1 21:24 apm.socket ``` real agent: ``` cnb@my-app:/var/run/datadog$ ls -la total 4 drwxr-xr-x 2 root root 80 Aug 1 21:30 . drwxr-xr-x 1 root root 4096 Aug 1 21:31 .. srwx-w--w- 1 root root 0 Aug 1 21:30 apm.socket ``` aiohttp doesn't seem to have a configurable way to set these permissions but it does let us create and manage a socket ourselves, so let's try that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions of the socket created by aiohttp aren't as permissive as
the ones set by the real agent. (see
aio-libs/aiohttp#4155)
from @devinsba:
test agent:
real agent:
aiohttp doesn't seem to have a configurable way
to set these permissions but it does let us create and
manage a socket ourselves, so let's try that.