Skip to content

[CHORE] Preserve Framework dsym as publish action artifact#59

Merged
sbarrio merged 1 commit into
developfrom
sbarrio/chore/preserve-framework-dsym-on-publish-action
Jun 29, 2026
Merged

[CHORE] Preserve Framework dsym as publish action artifact#59
sbarrio merged 1 commit into
developfrom
sbarrio/chore/preserve-framework-dsym-on-publish-action

Conversation

@sbarrio

@sbarrio sbarrio commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

It adds the generated DatadogWrapper.framework dSym file to the publish action artifact list, so it can be downloaded and preserved separately alongisde the nuget packages after the publish action has run.

Motivation

This way we can reupload the dsym manually if anything goes wrong during the release without having to recompile the whole module.

Copilot AI review requested due to automatic review settings June 22, 2026 09:27
@sbarrio
sbarrio requested a review from a team as a code owner June 22, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NuGet publish workflow to preserve the iOS native framework debug symbols (DatadogWrapper.framework.dSYM) as a downloadable GitHub Actions artifact, supporting post-release manual re-uploads without rebuilding the SDK.

Changes:

  • Uploads the generated iOS wrapper dSYM directory (bindings/Datadog.iOS.Binding/NativeReference/dSYMs/) as a separate workflow artifact.
  • Keeps the existing NuGet package artifact upload unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbarrio
sbarrio requested a review from rgaignault June 26, 2026 08:50
@sbarrio
sbarrio merged commit 953ad2b into develop Jun 29, 2026
14 checks passed
@sbarrio
sbarrio deleted the sbarrio/chore/preserve-framework-dsym-on-publish-action branch June 29, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants