[RUM-14555] DdSdk Core Configuration#6
Merged
sbarrio merged 1 commit intoMar 17, 2026
Conversation
Collaborator
Author
|
@codex review |
|
✨ Fix all issues with BitsAI or with Cursor
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c09b055770
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sbarrio
changed the base branch from
sbarrio/groundowrk-logs-module-and-documentation
to
sbarrio/RUM-14554/internal-logger
sbarrio
commented
Feb 18, 2026
sbarrio
left a comment
sbarrio
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looks good, left several comments that need to be addressed though.
Base automatically changed from
sbarrio/RUM-14554/internal-logger
to
feature/conservative
February 19, 2026 11:43
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
sbarrio
force-pushed
the
sbarrio/RUM-13927/sdk-core-configuration
branch
from
358619e to
a7f44ac
Compare
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7f44ac997
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sbarrio
force-pushed
the
sbarrio/RUM-13927/sdk-core-configuration
branch
from
a7f44ac to
9969f32
Compare
rgaignault
reviewed
Mar 16, 2026
sbarrio
force-pushed
the
sbarrio/RUM-13927/sdk-core-configuration
branch
from
9969f32 to
d73f348
Compare
Implement DdSdkConfiguration class with full SDK initialization parameters, pass them through the native bridge to iOS and Android SDKs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sbarrio
force-pushed
the
sbarrio/RUM-13927/sdk-core-configuration
branch
from
d73f348 to
75bd3e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref: https://datadoghq.atlassian.net/browse/RUM-14555
Implements the full core SDK configuration layer, wiring
DdSdkConfigurationthrough all three layers of the stack (C# → native bindings → iOS/Android SDKs), and adds comprehensive unit tests at every layer.Configuration object
New
DdSdkConfigurationclass underDatadogSdk.Maui.Configuration:ClientTokenstringEnvironmentstringTrackingConsentGrantedGranted,NotGranted,PendingSiteUs1Ap2,Us1FedServicestring?nullVerbositynullDEBUG,INFO,WARN,ERRORBatchSizenullSmall,Medium,LargeBatchProcessingLevelnullLow,Medium,HighUploadFrequencynullFrequent,Average,RareVersionstring?null_dd.versionin additionalConfigurationVersionSuffixstring?null_dd.version_suffixAdditionalConfigurationDictionary<string, object>?nullBuildAdditionalConfigurationhelperExtracted as a testable internal static method. Merges
Version/VersionSuffixinto the additional config dict without mutating the source, then passes all keys (including internal ones like_dd.needsClearTextHttp) through to the native layer unchanged._dd.needsClearTextHttpsupport (mirrors dd-sdk-reactnative#1195)When
AdditionalConfiguration["_dd.needsClearTextHttp"] = trueis set, the Android native wrapper calls_InternalProxy.allowClearTextHttp(builder), configuring OkHttp for plain HTTP transport. Intended for integration testing against local mock intake servers — not for production use.The example app includes
network_security_config.xmlwithcleartextTrafficPermitted="true"(referenced fromAndroidManifest.xml) to satisfy the Android OS-level cleartext restriction when testing with this flag.Native wrappers
Both iOS (
DatadogWrapper.swift) and Android (DatadogWrapper.kt)initialize()methods extended from 5–6 parameters to 10, accepting the full configuration surface:trackingConsent,batchSize,uploadFrequency,batchProcessingLevel, andadditionalConfiguration. iOS applies optional values directly to theDatadog.Configurationstruct. Android uses theConfiguration.Builderfluent API.Unit tests
BuildAdditionalConfiguration(version-only, suffix-only, both, merge-with-existing, immutability, internal key pass-through)mockkConstructor(Configuration.Builder::class)withanswers { self }to keep builder chain intact — verifies exact enum values (DatadogSite.EU1,BatchSize.LARGE,TrackingConsent.PENDING, etc.),_InternalProxy.allowClearTextHttpcallDocumentation
Updated
README.md,SPEC.md, andAGENTS.mdto reflect Phase 2 completion, new API signatures, test infrastructure, and theAdditionalConfigurationinternal key pattern.Test plan
./check.sh./build.shservice:datadog-maui-test env:dev🤖 Generated with Claude Code