[RUM-12388] [V3] Support SVG in Session Replay#1026
Closed
cdn34dd wants to merge 1 commit into
Closed
Conversation
maycmlee
approved these changes
Oct 24, 2025
maycmlee
left a comment
maycmlee
left a comment
Contributor
There was a problem hiding this comment.
Just a small suggestion, but approving
| yarn android | ||
| ``` | ||
|
|
||
| The `datadog-generate-sr-assets` CLI utility scans your codebase for SVG elements and pre-generates optimized assets that will be included in your native builds. |
Contributor
There was a problem hiding this comment.
Suggested change
| The `datadog-generate-sr-assets` CLI utility scans your codebase for SVG elements and pre-generates optimized assets that will be included in your native builds. | |
| The `datadog-generate-sr-assets` CLI utility scans your codebase for SVG elements and pre-generates optimized assets that are included in your native builds. |
Contributor
|
Let's not forget to also update the Podfile.lock for the benchmarks app 🙏 Also, won;t we have to replicate the mimeType change for iOS v3 as well?, I see dd-sdk-android rolled out a 3.2.0 including it (same as for v2), but iOS apparently hasn't done that yet, right? |
sbarrio
reviewed
Oct 27, 2025
Contributor
|
FYI: I merged the PR updating feature/v3 with the latest changes from develop, so this PR may not be necessary anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for tracking SVG images in React Native Session Replay.
Same as this PR: #985
Review checklist (to be filled by reviewers)