[FIX] Fix SDK compilation errors#1143
Merged
yugisu-flux merged 2 commits intoFeb 17, 2026
Merged
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: e70f205 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
yugisu-flux
force-pushed
the
dima/fix-flags-compile-errors
branch
from
February 16, 2026 08:26
881206f to
e08ff32
Compare
Contributor
Author
|
These changes fix the build errors: https://gitlab.ddbuild.io/DataDog/dd-react-native-nightly-tests/-/pipelines/96690464 |
yugisu-flux
changed the base branch from
develop
to
revert-1145-revert-1092-feature/flags
February 16, 2026 11:54
sbarrio
approved these changes
Feb 17, 2026
yugisu-flux
merged commit Feb 17, 2026
d81d6eb
into
revert-1145-revert-1092-feature/flags
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to fix the compilation errors showing for certain compilation conditions (like in this pipeline). These errors were caused by the usage of
@escaping RCTPromiseResolveBlockand@escaping RCTPromiseRejectBlockin the Flags SDK.Motivation
Some nightly tests failed to compile because of this compilation error
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)