[FIX] Cache maxDisplayRefreshRate on Android#1315
Open
sbarrio wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a performance issue on Android where Display.supportedModes was being queried on every frame callback when computing refresh-rate-normalized JS frame times. It introduces caching so the max display refresh rate is computed once and reused.
Changes:
- Cache the computed max display refresh rate in
DdSdkImplementationto avoid repeatedsupportedModescalls on each frame. - Standardize fallback refresh rate usage by using
DEFAULT_REFRESH_HZinstead of a hardcoded60.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fd890a2 to
494b06e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Raised by: #1313
maxDisplayRefreshRate was not being cached on Android, which was effectively calling display.supportedModes on every frame callback.
With this change, the value is calculated once, stored on a cached shared value and reused for every subsequent frame callback.
Additional Notes
Thanks @ivan-moego to for raising.
Review checklist (to be filled by reviewers)