fix(ddtrace/tracer): use "_dd.span_links" to get the span links in mo…

…cktracer
DataDog · Feb 21, 2025 · 0ae5db7 · 0ae5db7
1 parent 5ad4fed
commit 0ae5db7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/contrib/aws/aws-sdk-go-v2/internal/span_pointers/span_pointers_test.go b/contrib/aws/aws-sdk-go-v2/internal/span_pointers/span_pointers_test.go
@@ -159,7 +159,7 @@ func TestHandleS3Operation(t *testing.T) {
 			if tt.expectSuccess {
 				require.Len(t, spans, 1)
 				links := spans[0].Links()
-				assert.NotEmpty(t, links, "Expected span links to not be empty")
+				require.NotEmpty(t, links, "Expected span links to not be empty")
 
 				attributes := links[0].Attributes
 				assert.Equal(t, S3PointerKind, attributes["ptr.kind"])

diff --git a/ddtrace/mocktracer/mockspan.go b/ddtrace/mocktracer/mockspan.go
@@ -6,6 +6,7 @@
 package mocktracer // import "github.com/DataDog/dd-trace-go/v2/ddtrace/mocktracer"
 
 import (
+	"encoding/json"
 	"fmt"
 	"time"
 
@@ -207,9 +208,16 @@ func (s *Span) Unwrap() *tracer.Span {
 
 // Links returns the span's span links.
 func (s *Span) Links() []tracer.SpanLink {
-	return s.links
+	payload := s.Tag("_dd.span_links")
+	if payload == nil {
+		return nil
+	}
+	// Unmarshal the JSON payload into the SpanLink slice.
+	var links []tracer.SpanLink
+	json.Unmarshal([]byte(payload.(string)), &links)
+	return links
 }
 
 func (s *Span) AddSpanLink(link tracer.SpanLink) {
-	s.links = append(s.links, link)
+	s.sp.AddSpanLink(link)
 }