contrib/internal/httptrace: add inferred span identification tag (#3184)

DataDog · Feb 13, 2025 · 839b9bc · 839b9bc
1 parent 57c1cdc
commit 839b9bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/instrumentation/httptrace/httptrace_api_gateway_test.go b/instrumentation/httptrace/httptrace_api_gateway_test.go
@@ -61,6 +61,7 @@ func TestInferredProxySpans(t *testing.T) {
 		assert.Equal(t, "aws.apigateway", gwSpan.OperationName())
 		assert.Equal(t, "http.request", webReqSpan.OperationName())
 		assert.Equal(t, "example.com", gwSpan.Tag("service.name"))
+		assert.Equal(t, 1, gwSpan.Tag("_dd.inferred_span"))
 		assert.True(t, webReqSpan.ParentID() == gwSpan.SpanID())
 		assert.Equal(t, webReqSpan.Tag("http.status_code"), gwSpan.Tag("http.status_code"))
 		assert.Equal(t, webReqSpan.Tag("span.type"), gwSpan.Tag("span.type"))
@@ -102,6 +103,7 @@ func TestInferredProxySpans(t *testing.T) {
 		assert.Equal(t, "aws.apigateway", gwSpan.OperationName())
 		assert.Equal(t, "http.request", webReqSpan.OperationName())
 		assert.Equal(t, "example.com", gwSpan.Tag("service.name"))
+		assert.Equal(t, 1, gwSpan.Tag("_dd.inferred_span"))
 		assert.True(t, webReqSpan.ParentID() == gwSpan.SpanID())
 		assert.Equal(t, webReqSpan.Tag("http.status_code"), gwSpan.Tag("http.status_code"))
 		assert.Equal(t, webReqSpan.Tag("span.type"), gwSpan.Tag("span.type"))
@@ -186,6 +188,7 @@ func TestInferredProxySpans(t *testing.T) {
 		assert.Equal(t, "aws.apigateway", gwSpan.OperationName())
 		assert.Equal(t, "http.request", webReqSpan.OperationName())
 		assert.Equal(t, "example.com", gwSpan.Tag("service.name"))
+		assert.Equal(t, 1, gwSpan.Tag("_dd.inferred_span"))
 		assert.True(t, webReqSpan.ParentID() == gwSpan.SpanID())
 		assert.Equal(t, webReqSpan.Tag("http.status_code"), gwSpan.Tag("http.status_code"))
 		assert.Equal(t, webReqSpan.Tag("span.type"), gwSpan.Tag("span.type"))

diff --git a/instrumentation/httptrace/inferred_proxy.go b/instrumentation/httptrace/inferred_proxy.go
@@ -142,6 +142,7 @@ func startInferredProxySpan(requestProxyContext *proxyContext, parent *tracer.Sp
 			cfg.Tags[ext.HTTPURL] = requestProxyContext.domainName + requestProxyContext.path
 			cfg.Tags[ext.HTTPRoute] = requestProxyContext.path
 			cfg.Tags[ext.ResourceName] = fmt.Sprintf("%s %s", requestProxyContext.method, requestProxyContext.path)
+			cfg.Tags["_dd.inferred_span"] = 1
 			cfg.Tags["stage"] = requestProxyContext.stage
 		},
 	)