Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: update gen supported versions workflow for v2 #3178

Merged

Conversation

quinna-h
Copy link
Contributor

What does this PR do?

Modified the GetPackages method in #3078, small fix to reflect the new method return type.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@quinna-h quinna-h requested review from a team as code owners February 12, 2025 18:12
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 12, 2025

Datadog Report

Branch report: quinna.halim/v2-update-gen-supported-versions-workflow
Commit report: 8944022
Test service: dd-trace-go

❌ 10 Failed (0 Known Flaky), 2672 Passed, 67 Skipped, 1m 32.52s Total Time

❌ Failed Tests (10)

This report shows up to 5 failed tests.

  • TestInjectTraceContextSizeLimit - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/eventbridge - Details

    Expand for error
     Failed
     
     === RUN   TestInjectTraceContextSizeLimit
     --- FAIL: TestInjectTraceContextSizeLimit (0.01s)
    
  • TestInjectTraceContextSizeLimit/Do_not_inject_when_payload_is_too_large - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/eventbridge - Details

    Expand for error
     Failed
     
     === RUN   TestInjectTraceContextSizeLimit/Do_not_inject_when_payload_is_too_large
         --- FAIL: TestInjectTraceContextSizeLimit/Do_not_inject_when_payload_is_too_large (0.00s)
     panic: runtime error: invalid memory address or nil pointer dereference [recovered]
     	panic: runtime error: invalid memory address or nil pointer dereference
     [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x120a759]
     
     goroutine 57 [running]:
     testing.tRunner.func1.2({0x1307ba0, 0x1c2e410})
     ...
    
  • TestInjectTraceContext - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/sns - Details

    Expand for error
     Failed
     
     === RUN   TestInjectTraceContext
     --- FAIL: TestInjectTraceContext (0.05s)
    
  • TestInjectTraceContext/No_injection_when_at_max_attributes - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/sns - Details

    Expand for error
     Failed
     
     === RUN   TestInjectTraceContext/No_injection_when_at_max_attributes
         --- FAIL: TestInjectTraceContext/No_injection_when_at_max_attributes (0.01s)
     panic: runtime error: invalid memory address or nil pointer dereference [recovered]
     	panic: runtime error: invalid memory address or nil pointer dereference
     [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1208d7f]
     
     goroutine 55 [running]:
     testing.tRunner.func1.2({0x1304e80, 0x1c2a410})
     ...
    
  • TestInjectTraceContext - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/sqs - Details

    Expand for error
     Failed
     
     === RUN   TestInjectTraceContext
     --- FAIL: TestInjectTraceContext (0.05s)
    

@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-02-12 18:42:42

Comparing candidate commit 889eb09 in PR branch quinna.halim/v2-update-gen-supported-versions-workflow with baseline commit 22115e9 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@quinna-h quinna-h merged commit a69e484 into v2-dev Feb 13, 2025
121 of 159 checks passed
@quinna-h quinna-h deleted the quinna.halim/v2-update-gen-supported-versions-workflow branch February 13, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants