Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: replace telemetry with newtelemetry (cherry-pick v2) #3214

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Cherry-pick of #3136

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 20, 2025

Datadog Report

Branch report: eliott.bouhana/remove-oldtelemetry-v2
Commit report: e110ae1
Test service: dd-trace-go

❌ 8 Failed (0 Known Flaky), 4307 Passed, 66 Skipped, 3m 38.49s Total Time

❌ Failed Tests (8)

This report shows up to 5 failed tests.

  • TestHandleS3Operation - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/internal/span_pointers - Details

    Expand for error
     Failed
     
     === RUN   TestHandleS3Operation
     --- FAIL: TestHandleS3Operation (0.01s)
    
  • TestHandleS3Operation/basic_operation - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/internal/span_pointers - Details

    Expand for error
     Failed
     
     === RUN   TestHandleS3Operation/basic_operation
         span_pointers_test.go:162: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-sdk-go-v2/internal/span_pointers/span_pointers_test.go:162
             	Error:      	Should NOT be empty, but was []
             	Test:       	TestHandleS3Operation/basic_operation
             	Messages:   	Expected span links to not be empty
         --- FAIL: TestHandleS3Operation/basic_operation (0.00s)
     panic: runtime error: index out of range [0] with length 0 [recovered]
     ...
    
  • TestFetchMessageFunctional - github.com/DataDog/dd-trace-go/contrib/segmentio/kafka-go/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestFetchMessageFunctional
         kafka_test.go:316: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/segmentio/kafka-go/kafka_test.go:316
             	Error:      	Not equal: 
             	            	expected: string("gosegtest")
             	            	actual  : <nil>(<nil>)
             	Test:       	TestFetchMessageFunctional
         kafka_test.go:337: 
     ...
    
  • TestReadMessageFunctional - github.com/DataDog/dd-trace-go/contrib/segmentio/kafka-go/v2 - Details

    Expand for error
     Failed
     
     === RUN   TestReadMessageFunctional
         kafka_test.go:230: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/segmentio/kafka-go/kafka_test.go:230
             	Error:      	Not equal: 
             	            	expected: string("gosegtest")
             	            	actual  : <nil>(<nil>)
             	Test:       	TestReadMessageFunctional
         kafka_test.go:251: 
     ...
    
  • TestTelemetry - github.com/DataDog/dd-trace-go/v2/ddtrace/opentelemetry - Details

    Expand for error
     Failed
     
     === RUN   TestTelemetry
     --- FAIL: TestTelemetry (0.46s)
    

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-20 17:23:39

Comparing candidate commit 87b41a8 in PR branch eliott.bouhana/remove-oldtelemetry-v2 with baseline commit 4179308 in branch v2-dev.

Found 4 performance improvements and 3 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

scenario:BenchmarkInjectW3C-24

  • 🟩 execution_time [-131.540ns; -99.860ns] or [-3.169%; -2.406%]

scenario:BenchmarkOTelApiWithCustomTags/otel_api-24

  • 🟥 allocated_mem [+115 bytes; +128 bytes] or [+2.371%; +2.632%]
  • 🟥 allocations [+2; +2] or [+4.651%; +4.651%]
  • 🟥 execution_time [+375.694ns; +446.606ns] or [+5.158%; +6.131%]

scenario:BenchmarkSetTagMetric-24

  • 🟩 execution_time [-10.372ns; -8.448ns] or [-8.229%; -6.703%]

scenario:BenchmarkSetTagString-24

  • 🟩 execution_time [-9.224ns; -7.216ns] or [-7.749%; -6.062%]

scenario:BenchmarkSetTagStringer-24

  • 🟩 execution_time [-10.104ns; -5.316ns] or [-6.802%; -3.578%]

@darccio darccio marked this pull request as ready for review February 21, 2025 14:20
@darccio darccio requested review from a team as code owners February 21, 2025 14:20
@darccio darccio merged commit 44ede56 into v2-dev Feb 21, 2025
160 of 181 checks passed
@darccio darccio deleted the eliott.bouhana/remove-oldtelemetry-v2 branch February 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants