Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rueidis test #3281

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Fix Rueidis test #3281

merged 1 commit into from
Mar 12, 2025

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Mar 11, 2025

What does this PR do?

Fix Rueidis test.

error
go run github.com/DataDog/orchestrion go test ./rueidis/...
INFO:ddapm_test_agent.agent:Trace request stall seconds setting set to 0.0.
WARNING:ddapm_test_agent.agent:default snapshot directory '/home/ubuntu/workspace/dd-trace-go/internal/orchestrion/_integration/rueidis/snapshots' does not exist or is not readable. Snapshotting will not work.
--- FAIL: Test (5.25s)
    agent.go:67: Starting /home/ubuntu/.pyenv/shims/ddapm-test-agent on port 38227
    generated_test.go:19: Running setup
    docker.go:1392: Failed to get image auth for https://index.docker.io/v1/. Setting empty credentials for the image: redis:7-alpine. Error is: credentials not found in native keychain
    lifecycle.go:77: 🐳 Creating container for image redis:7-alpine
    lifecycle.go:77: 🐳 Creating container for image testcontainers/ryuk:0.11.0
    lifecycle.go:83: ✅ Container created: d1067f65a9e2
    lifecycle.go:89: 🐳 Starting container: d1067f65a9e2
    lifecycle.go:95: ✅ Container started: d1067f65a9e2
    lifecycle.go:285: ⏳ Waiting for container id d1067f65a9e2 image: testcontainers/ryuk:0.11.0. Waiting for: &{Port:8080/tcp timeout:<nil> PollInterval:100ms skipInternalCheck:false}
    lifecycle.go:101: 🔔 Container is ready: d1067f65a9e2
    lifecycle.go:83: ✅ Container created: e13240c1f836
    lifecycle.go:89: 🐳 Starting container: e13240c1f836
    lifecycle.go:95: ✅ Container started: e13240c1f836
    lifecycle.go:285: ⏳ Waiting for container id e13240c1f836 image: redis:7-alpine. Waiting for: &{timeout:<nil> deadline:0xc0003ec548 Strategies:[0xc000308a20]}
    logs.go:29: 1:C 11 Mar 2025 10:27:10.482 * oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
        
    logs.go:29: 1:C 11 Mar 2025 10:27:10.482 * Redis version=7.4.2, bits=64, commit=00000000, modified=0, pid=1, just started
        
    logs.go:29: 1:C 11 Mar 2025 10:27:10.482 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.482 * monotonic clock: POSIX clock_gettime
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.483 * Running mode=standalone, port=6379.
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.483 * Server initialized
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.483 * Ready to accept connections tcp
        
    lifecycle.go:101: 🔔 Container is ready: e13240c1f836
    lifecycle.go:107: 🐳 Stopping container: e13240c1f836
    logs.go:29: 1:signal-handler (1741688830) Received SIGTERM scheduling shutdown...
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.887 * User requested shutdown...
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.887 * Saving the final RDB snapshot before exiting.
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.892 * DB saved on disk
        
    logs.go:29: 1:M 11 Mar 2025 10:27:10.892 # Redis is now ready to exit, bye bye...
        
    lifecycle.go:113: ✅ Container stopped: e13240c1f836
    lifecycle.go:119: 🐳 Terminating container: e13240c1f836
    lifecycle.go:125: 🚫 Container terminated: e13240c1f836
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xd721a5]

goroutine 36 [running]:
testing.tRunner.func1.2({0x13fc440, 0x230a5c0})
	/snap/go/10866/src/testing/testing.go:1734 +0x21c
testing.tRunner.func1()
	/snap/go/10866/src/testing/testing.go:1737 +0x35e
panic({0x13fc440?, 0x230a5c0?})
	/snap/go/10866/src/runtime/panic.go:792 +0x132
github.com/DataDog/dd-trace-go/v2/instrumentation.(*Instrumentation).ServiceName(0xc000227200, 0x0, 0x0)
	/home/ubuntu/workspace/dd-trace-go/instrumentation/instrumentation.go:67 +0x85
github.com/DataDog/dd-trace-go/contrib/redis/rueidis/v2.defaultConfig()
	/home/ubuntu/workspace/dd-trace-go/contrib/redis/rueidis/option.go:24 +0x39
github.com/DataDog/dd-trace-go/contrib/redis/rueidis/v2.NewClient({0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, {{0x0, {0x0, ...}, ...}, ...}, ...}, ...)
	/home/ubuntu/workspace/dd-trace-go/contrib/redis/rueidis/rueidis.go:40 +0x7a
github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/rueidis.(*TestCase).Setup(0xc000275eb0, {0xc000093f18?, 0x0?}, 0xc0002461c0)
	<generated>:1 +0x12b
github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/internal/harness.Run(0xc0002461c0, {0x1864538, 0xc000275eb0})
	/home/ubuntu/workspace/dd-trace-go/internal/orchestrion/_integration/internal/harness/harness.go:63 +0x20f
github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/rueidis.Test(0xc0002461c0)
	/home/ubuntu/workspace/dd-trace-go/internal/orchestrion/_integration/rueidis/generated_test.go:19 +0x33
testing.tRunner(0xc0002461c0, 0x16ee4f0)
	/snap/go/10866/src/testing/testing.go:1792 +0xf4
created by testing.(*T).Run in goroutine 1
	/snap/go/10866/src/testing/testing.go:1851 +0x42b
FAIL	github.com/DataDog/dd-trace-go/v2/internal/orchestrion/_integration/rueidis	5.287s
FAIL
exit status 1

Motivation

This failure blocks other PRs.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: keisku/fix-rueidis
Commit report: 8e33db1
Test service: dd-trace-go

✅ 0 Failed, 4381 Passed, 65 Skipped, 3m 40.27s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-11 23:36:54

Comparing candidate commit 82e5cfe in PR branch keisku/fix-rueidis with baseline commit 5084632 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

@keisku keisku changed the title Fix Rueidis orchestrion test Fix CI failures Mar 11, 2025
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 11, 2025
@keisku keisku changed the title Fix CI failures Fix CI failures for rueidis and kafka Mar 11, 2025
@keisku keisku marked this pull request as ready for review March 11, 2025 11:15
@keisku keisku requested review from a team as code owners March 11, 2025 11:15
@keisku keisku changed the title Fix CI failures for rueidis and kafka Fix CI failures Mar 11, 2025
@keisku keisku force-pushed the keisku/fix-rueidis branch 3 times, most recently from caeef87 to 57a0528 Compare March 11, 2025 12:14
@darccio darccio force-pushed the keisku/fix-rueidis branch from 25d06d8 to d470f1a Compare March 11, 2025 21:30
Signed-off-by: keisku <[email protected]>
@keisku keisku force-pushed the keisku/fix-rueidis branch from d470f1a to 82e5cfe Compare March 11, 2025 23:07
@keisku keisku changed the title Fix CI failures Fix Rueidis test Mar 11, 2025
@darccio darccio merged commit 5bb42a9 into v2-dev Mar 12, 2025
164 of 169 checks passed
@darccio darccio deleted the keisku/fix-rueidis branch March 12, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants