Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piotr wolski/2.0 service names #3284

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

piochelepiotr
Copy link
Collaborator

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@piochelepiotr piochelepiotr requested review from a team as code owners March 11, 2025 18:22
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: piotr-wolski/2.0-service-names
Commit report: 453bee9
Test service: dd-trace-go

✅ 0 Failed, 4379 Passed, 65 Skipped, 3m 36.98s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-11 18:51:43

Comparing candidate commit d69b25f in PR branch piotr-wolski/2.0-service-names with baseline commit 4dcdf80 in branch release-v2.0.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@darccio darccio merged commit 6599f67 into release-v2.0.x Mar 11, 2025
162 of 168 checks passed
@darccio darccio deleted the piotr-wolski/2.0-service-names branch March 11, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants