Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] [APM DCS R&D] Incorporate synctest #3286

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hannahkm
Copy link
Contributor

What does this PR do?

Experiments with using synctest on our slowest tests.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: apmlp-rd/synctest
Commit report: d086ffa
Test service: dd-trace-go

✅ 0 Failed, 5355 Passed, 72 Skipped, 2m 51.44s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-11 21:23:10

Comparing candidate commit fd38ed7 in PR branch apmlp-rd/synctest with baseline commit 135e802 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant