Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-sdk-v2 error in the orchestrion test #3287

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Mar 12, 2025

What does this PR do?

Fix this error in the orchestrion test.

Error: aws.v2/load_default_config.go:34:6: cfg.BaseEndpoint undefined (type "github.com/aws/aws-sdk-go-v2/aws".Config has no field or method BaseEndpoint)
Error: aws.v2/new_config.go:30:6: cfg.BaseEndpoint undefined (type *"github.com/aws/aws-sdk-go-v2/aws".Config has no field or method BaseEndpoint)
Error: aws.v2/struct_literal.go:30:3: unknown field BaseEndpoint in struct literal of type "github.com/aws/aws-sdk-go-v2/aws".Config
Error: aws.v2/struct_literal_ptr.go:30:3: unknown field BaseEndpoint in struct literal of type "github.com/aws/aws-sdk-go-v2/aws".Config

aws/aws-sdk-go-v2#2328 added cfg.BaseEndpoint and was released as github.com/aws/aws-sdk-go-v2/config v1.22.1.

Motivation

#3285

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 12, 2025
@keisku keisku force-pushed the keisku/fix-aws-v2-test branch from a92a097 to a774096 Compare March 12, 2025 04:05
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 12, 2025

Datadog Report

Branch report: keisku/fix-aws-v2-test
Commit report: 79682f1
Test service: dd-trace-go

✅ 0 Failed, 4381 Passed, 65 Skipped, 3m 36.48s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-12 04:34:36

Comparing candidate commit a774096 in PR branch keisku/fix-aws-v2-test with baseline commit 5084632 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

@keisku keisku marked this pull request as ready for review March 12, 2025 04:34
@keisku keisku requested review from a team as code owners March 12, 2025 04:34
@darccio darccio merged commit 579db6c into v2-dev Mar 12, 2025
185 of 190 checks passed
@darccio darccio deleted the keisku/fix-aws-v2-test branch March 12, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants