Skip to content

fix: properly report codeowners on tests #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: properly report codeowners on tests #4057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14a71ef
use glob regex
hannahkm Oct 20, 2025
d6504ca
debug: echo each line in the xml file
hannahkm Oct 21, 2025
06eb0ad
fix: normalize how we access $TEST_RESULTS between contrib and core t…
hannahkm Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/add-codeowners/codeowners.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ for file in gotestsum-report*.xml; do
echo -e "\n" >> $file

while read p; do
echo "line: $p"
# we might try to report gotestsum-report.xml multiple times, so don't
# calculate codeowners more times than we need
if [[ "$p" =~ \<testcase && ! "$p" =~ "file=" ]]; then
Expand Down
66 changes: 35 additions & 31 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,67 +3,71 @@
# default owner
* @DataDog/dd-trace-go-guild
# tracing
/contrib @DataDog/apm-go @Datadog/apm-idm-go
/ddtrace @DataDog/apm-go
/contrib @DataDog/apm-go @Datadog/apm-idm-go
/ddtrace @DataDog/apm-go

# profiling
/profiler @DataDog/profiling-go
/internal/traceprof @DataDog/profiling-go
/profiler @DataDog/profiling-go
/internal/traceprof @DataDog/profiling-go

# appsec
/appsec @DataDog/asm-go
/internal/appsec @DataDog/asm-go
/instrumentation/appsec @DataDog/asm-go
/appsec @DataDog/asm-go
/internal/appsec @DataDog/asm-go
/instrumentation/appsec @DataDog/asm-go
/contrib/**/*appsec*.go @DataDog/asm-go
/.github/workflows/appsec.yml @DataDog/asm-go
/contrib/envoyproxy @DataDog/asm-go
/contrib/haproxy @DataDog/asm-go
/contrib/k8s.io/gateway-api @DataDog/asm-go
/contrib/envoyproxy @DataDog/asm-go
/contrib/haproxy @DataDog/asm-go
/contrib/k8s.io/gateway-api @DataDog/asm-go

# capabilities - config, dynamic config, remote config
/internal/env @DataDog/apm-sdk-capabilities-go
/internal/stableconfig @DataDog/apm-sdk-capabilities-go
/internal/globalconfig @DataDog/apm-sdk-capabilities-go
/internal/remoteconfig @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/dynamic_config.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/remote_config.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/otel_dd_mappings.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/dynamic_config.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/remote_config.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/otel_dd_mappings.go @DataDog/apm-sdk-capabilities-go

# capabilities - telemetry
/internal/telemetry @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/telemetry.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/telemetry.go @DataDog/apm-sdk-capabilities-go

# capabilities - sampling
/ddtrace/tracer/tracer.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/sampler.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/rules_sampler.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/tracer.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/sampler.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/rules_sampler.go @DataDog/apm-sdk-capabilities-go
/internal/samplernames @DataDog/apm-sdk-capabilities-go

# capabilities - context, propagation, injection/extraction
/ddtrace/baggage @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/textmap.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/spancontext.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/context.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/propagator.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/propagating_tags.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/textmap.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/spancontext.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/context.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/propagator.go @DataDog/apm-sdk-capabilities-go
/ddtrace/tracer/propagating_tags.go @DataDog/apm-sdk-capabilities-go

# capabilities- OTel integration
/ddtrace/opentelemetry @DataDog/apm-sdk-capabilities-go

# datastreams
/datastreams @Datadog/data-streams-monitoring
/internal/datastreams @Datadog/data-streams-monitoring
/datastreams @Datadog/data-streams-monitoring
/internal/datastreams @Datadog/data-streams-monitoring

# civisibility
/civisibility @DataDog/ci-app-libraries
/internal/civisibility @DataDog/ci-app-libraries
/civisibility @DataDog/ci-app-libraries
/internal/civisibility @DataDog/ci-app-libraries

# llm observability
/llmobs @DataDog/ml-observability
/internal/llmobs @DataDog/ml-observability
/llmobs @DataDog/ml-observability
/internal/llmobs @DataDog/ml-observability

# Gitlab configuration
.gitlab-ci.yml @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability
/.gitlab-ci @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability
/.gitlab-ci @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability

# Orchestrion
/internal/orchestrion @DataDog/apm-orchestrion
/internal/orchestrion @DataDog/apm-orchestrion
/**/orchestrion.yml @DataDog/apm-orchestrion

# Serverless
Expand All @@ -76,4 +80,4 @@
**/go.mod
**/go.sum
go.work
go.work.sum
go.work.sum
3 changes: 3 additions & 0 deletions scripts/ci_test_contrib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export GOEXPERIMENT=synctest # TODO: remove once go1.25 is the minimum supported

report_error=0

TEST_RESULTS="${TEST_RESULTS:-.}"
mkdir -p "$TEST_RESULTS"

for contrib in $CONTRIBS; do
echo "Testing contrib module: $contrib"
contrib_id=$(echo "$contrib" | sed 's/^\.\///g;s/[\/\.]/_/g')
Expand Down
Loading