Skip to content

Conversation

@hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Oct 24, 2025

What does this PR do?

Throws an if: always() onto checkout steps so that it will always run, since we always want to upload test results to CI.

Motivation

We already had if: always() on upload steps. But failing tests would cause steps without the if: always() flag to be skipped, which can cause issues since we would be skipping an essential checkout step. The CI upload would fail, and we miss test failure information.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2025

Benchmarks

Benchmark execution time: 2025-10-24 21:14:26

Comparing candidate commit 1609bf7 in PR branch hannahkm/fix-ci with baseline commit 3d45ade in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 24, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1609bf7 | Docs | Was this helpful? Give us feedback!

@hannahkm hannahkm marked this pull request as ready for review October 24, 2025 17:18
@hannahkm hannahkm requested review from a team as code owners October 24, 2025 17:18
@hannahkm
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 24, 2025

View all feedbacks in Devflow UI.

2025-10-24 21:02:13 UTC ℹ️ Start processing command /merge


2025-10-24 21:02:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-10-24 21:27:25 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-24 21:40:08 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants