-
Notifications
You must be signed in to change notification settings - Fork 484
fix: failing tests sometimes cause CI uploads to get skipped #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Throws an
if: always()onto checkout steps so that it will always run, since we always want to upload test results to CI.Motivation
We already had
if: always()on upload steps. But failing tests would cause steps without theif: always()flag to be skipped, which can cause issues since we would be skipping an essential checkout step. The CI upload would fail, and we miss test failure information.Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!